You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "danwatford (via GitHub)" <gi...@apache.org> on 2023/04/05 11:21:27 UTC

[GitHub] [ofbiz-framework] danwatford commented on pull request #517: Codenarc integration

danwatford commented on PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1497323596

   @gilPts, It looks like we are getting close to completing this review :)
   
   For the conflicting files, BalanceSheet.groovy has changed quite significantly since the CodeNarc Integration work began. Would it be worth copying the latest BalanceSheet.groovy from trunk and then applying the CodeNarc cleanup.
   
   I'm not sure what would be the cleanest way to do this and keep git happy? Any Git experts on hand to comment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org