You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/06/30 00:06:23 UTC
[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11007: Fix a typo in snapshot lock
Jackie-Jiang opened a new pull request, #11007:
URL: https://github.com/apache/pinot/pull/11007
This is an urgent fix. We should add a test for snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11007: Fix a typo in snapshot lock
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11007:
URL: https://github.com/apache/pinot/pull/11007#discussion_r1247274246
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -244,7 +244,7 @@ public void replaceSegment(ImmutableSegment segment, IndexSegment oldSegment) {
} finally {
finishOperation();
if (_enableSnapshot) {
- _snapshotLock.readLock().lock();
+ _snapshotLock.readLock().unlock();
Review Comment:
🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11007: Fix a typo in snapshot lock
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11007:
URL: https://github.com/apache/pinot/pull/11007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org