You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/22 21:22:51 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #15334: [FLINK-21550][tests] Harden ZooKeeperHaServicesTest.testSimpleClose

tillrohrmann opened a new pull request #15334:
URL: https://github.com/apache/flink/pull/15334


   This commit hardens the ZooKeeperHaServicesTest by not busy loop waiting with a timeout
   on a leader election but instead to use LeaderRetrievalUtils.LeaderConnectionInfoListener
   which offers a future which is completed when the leader is elected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15334: [FLINK-21550][tests] Harden ZooKeeperHaServicesTest.testSimpleClose

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15334:
URL: https://github.com/apache/flink/pull/15334#issuecomment-804413843


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2f10b653e8998edd9faee3b086e6baa8d55503a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15218",
       "triggerID" : "2f10b653e8998edd9faee3b086e6baa8d55503a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f10b653e8998edd9faee3b086e6baa8d55503a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15218) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15334: [FLINK-21550][tests] Harden ZooKeeperHaServicesTest.testSimpleClose

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15334:
URL: https://github.com/apache/flink/pull/15334#issuecomment-804405970


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 2f10b653e8998edd9faee3b086e6baa8d55503a3 (Mon Mar 22 21:25:14 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #15334: [FLINK-21550][tests] Harden ZooKeeperHaServicesTest.testSimpleClose

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #15334:
URL: https://github.com/apache/flink/pull/15334


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #15334: [FLINK-21550][tests] Harden ZooKeeperHaServicesTest.testSimpleClose

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #15334:
URL: https://github.com/apache/flink/pull/15334#issuecomment-804896144


   Thanks for the review @zentol. The failing test is unrelated. Merging this PR now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15334: [FLINK-21550][tests] Harden ZooKeeperHaServicesTest.testSimpleClose

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15334:
URL: https://github.com/apache/flink/pull/15334#issuecomment-804413843


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2f10b653e8998edd9faee3b086e6baa8d55503a3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15218",
       "triggerID" : "2f10b653e8998edd9faee3b086e6baa8d55503a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f10b653e8998edd9faee3b086e6baa8d55503a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15218) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15334: [FLINK-21550][tests] Harden ZooKeeperHaServicesTest.testSimpleClose

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15334:
URL: https://github.com/apache/flink/pull/15334#issuecomment-804413843


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2f10b653e8998edd9faee3b086e6baa8d55503a3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f10b653e8998edd9faee3b086e6baa8d55503a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f10b653e8998edd9faee3b086e6baa8d55503a3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org