You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mintsweet (via GitHub)" <gi...@apache.org> on 2023/03/01 05:22:38 UTC
[GitHub] [incubator-devlake] mintsweet opened a new pull request, #4554: fix(config-ui): some bugs
mintsweet opened a new pull request, #4554:
URL: https://github.com/apache/incubator-devlake/pull/4554
### Summary
1. Adjust the placeholder for github transformation.
2. payload error from create bp.
3. delete webhook in project does not update bp.
4. endpoint version error in connection form.
### Screenshots
1.

2.

3. Self-tested
4.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #4554: fix(config-ui): some bugs
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh merged PR #4554:
URL: https://github.com/apache/incubator-devlake/pull/4554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4554: fix(config-ui): some bugs
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #4554:
URL: https://github.com/apache/incubator-devlake/pull/4554#discussion_r1121681793
##########
config-ui/src/plugins/register/gitlab/config.tsx:
##########
@@ -42,7 +42,7 @@ export const GitLabConfig: PluginConfigType = {
key: 'endpoint',
multipleVersions: {
cloud: 'https://gitlab.com/api/v4/',
- server: '',
+ server: '(v11+)',
Review Comment:
I don't want to complicate this configuration, this is currently the easiest way I can think of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4554: fix(config-ui): some bugs
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on code in PR #4554:
URL: https://github.com/apache/incubator-devlake/pull/4554#discussion_r1121410713
##########
config-ui/src/plugins/register/github/config.tsx:
##########
@@ -42,7 +42,7 @@ export const GitHubConfig: PluginConfigType = {
key: 'endpoint',
multipleVersions: {
cloud: 'https://api.github.com/',
- server: '',
+ server: ' ',
Review Comment:
why a space added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4554: fix(config-ui): some bugs
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on code in PR #4554:
URL: https://github.com/apache/incubator-devlake/pull/4554#discussion_r1121411580
##########
config-ui/src/plugins/register/gitlab/config.tsx:
##########
@@ -42,7 +42,7 @@ export const GitLabConfig: PluginConfigType = {
key: 'endpoint',
multipleVersions: {
cloud: 'https://gitlab.com/api/v4/',
- server: '',
+ server: '(v11+)',
Review Comment:
adding version directly in input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4554: fix(config-ui): some bugs
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #4554:
URL: https://github.com/apache/incubator-devlake/pull/4554#discussion_r1121680883
##########
config-ui/src/plugins/register/github/config.tsx:
##########
@@ -42,7 +42,7 @@ export const GitHubConfig: PluginConfigType = {
key: 'endpoint',
multipleVersions: {
cloud: 'https://api.github.com/',
- server: '',
+ server: ' ',
Review Comment:
Because I use whether the server exists to determine whether it is supported.
But the github server does not support the version, so I use a space to replace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org