You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by as...@apache.org on 2022/02/19 01:29:48 UTC

[impala] 03/03: IMPALA-11131: Replace 'cnd_cwnd' with 'snd_cwnd' in www/rpcz.tmpl

This is an automated email from the ASF dual-hosted git repository.

asherman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit e2ee736f9a4cf9900bfb7c67dc359bbff6a6c000
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Thu Feb 17 13:35:11 2022 -0800

    IMPALA-11131: Replace 'cnd_cwnd' with 'snd_cwnd' in www/rpcz.tmpl
    
    This patch fixes a typo in www/rpcz.tmpl. The javascript at the end of
    tmpl file refer to a json key 'cnd_cwnd', but the correct one should be
    'snd_cwnd'. This typo caused DataTables script to repeatedly show warning
    dialog pop up with message such as follow:
    
    DataTables warning: table id=inbound_per_conn_metrics - Requested
    unknown parameter '4' for row 0, column 4.
    For more information about this error, please see
    http://datatables.net/tn/4
    
    Testing:
    - Ran Q4 of TPC-DS against tpcds_parquet table manually. Verified that
      the page display the KRPC inbound/outbound connections table properly
      without any warning dialog.
    
    Change-Id: Ibf53f3420b447a895223642df3e9e1c7d0aee7df
    Reviewed-on: http://gerrit.cloudera.org:8080/18249
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 www/rpcz.tmpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/rpcz.tmpl b/www/rpcz.tmpl
index 802ccf9..cbe704f 100644
--- a/www/rpcz.tmpl
+++ b/www/rpcz.tmpl
@@ -300,7 +300,7 @@ function update_krpc_conn_metrics_datatable(json) {
     return [[row["remote_ip"], row["num_calls_in_flight"], row["outbound_queue_size"],
              row["socket_stats"]["rtt"],
              row["socket_stats"]["rttvar"],
-             row["socket_stats"]["cnd_cwnd"],
+             row["socket_stats"]["snd_cwnd"],
              row["socket_stats"]["total_retrans"],
              row["socket_stats"]["pacing_rate"],
              row["socket_stats"]["max_pacing_rate"],
@@ -321,7 +321,7 @@ function update_krpc_inbound_conn_metrics_datatable(json) {
     return [[row["remote_ip"], row["num_calls_in_flight"],
              row["socket_stats"]["rtt"],
              row["socket_stats"]["rttvar"],
-             row["socket_stats"]["cnd_cwnd"],
+             row["socket_stats"]["snd_cwnd"],
              row["socket_stats"]["total_retrans"],
              row["socket_stats"]["pacing_rate"],
              row["socket_stats"]["max_pacing_rate"],