You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2025/01/22 08:57:13 UTC
[PR] Python: Add Python as a dependency [iceberg-rust]
Fokko opened a new pull request, #906:
URL: https://github.com/apache/iceberg-rust/pull/906
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Python: Add Python as a dependency [iceberg-rust]
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
trim21 commented on code in PR #906:
URL: https://github.com/apache/iceberg-rust/pull/906#discussion_r1924944538
##########
bindings/python/pyproject.toml:
##########
@@ -33,8 +33,12 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
+ "Programming Language :: Python :: 3.13",
]
+[tool.poetry.dependencies]
+python = "^3.9, !=3.9.7"
Review Comment:
you are not using poetry as package manager in this project so you should not add this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Python: Add Python as a dependency [iceberg-rust]
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
trim21 commented on code in PR #906:
URL: https://github.com/apache/iceberg-rust/pull/906#discussion_r1924944538
##########
bindings/python/pyproject.toml:
##########
@@ -33,8 +33,12 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
+ "Programming Language :: Python :: 3.13",
]
+[tool.poetry.dependencies]
+python = "^3.9, !=3.9.7"
Review Comment:
you are not using poetry as package manager in this project but actually maturin so you should not add this. if you want to disallow `3.9.7` please add it to `project.requires-python`
##########
bindings/python/pyproject.toml:
##########
@@ -33,8 +33,12 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
+ "Programming Language :: Python :: 3.13",
]
+[tool.poetry.dependencies]
+python = "^3.9, !=3.9.7"
Review Comment:
you are not using poetry as package manager in this project but actually maturin so you should not add this.
If you want to disallow `3.9.7` please add it to `project.requires-python`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Python: Add Python as a dependency [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed pull request #906: Python: Add Python as a dependency
URL: https://github.com/apache/iceberg-rust/pull/906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Python: Add Python as a dependency [iceberg-rust]
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
trim21 commented on code in PR #906:
URL: https://github.com/apache/iceberg-rust/pull/906#discussion_r1924944538
##########
bindings/python/pyproject.toml:
##########
@@ -33,8 +33,12 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
+ "Programming Language :: Python :: 3.13",
]
+[tool.poetry.dependencies]
+python = "^3.9, !=3.9.7"
Review Comment:
you are not using poetry as package manager in this project so you should not add this. if you want to disallow `3.9.7` please add it to `project.requires-python`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Python: Add Python as a dependency [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #906:
URL: https://github.com/apache/iceberg-rust/pull/906#discussion_r1924945946
##########
bindings/python/pyproject.toml:
##########
@@ -33,8 +33,12 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
+ "Programming Language :: Python :: 3.13",
]
+[tool.poetry.dependencies]
+python = "^3.9, !=3.9.7"
Review Comment:
Yes, I'm just reading up on this. I think this is incorrect indeed. Thanks for pointing out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org