You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "desruisseaux (via GitHub)" <gi...@apache.org> on 2026/07/29 14:18:22 UTC

[PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

desruisseaux opened a new pull request, #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097

   The plugins must be upgraded for compatibility with Java 26. But we do not need any more to declare those version numbers ourselves. It is now sufficient to inherit them from the parent `pom.xml`.
   
   This pull request opportunistically changes the `invoker.toolchain.jdk.version` property of an integration test to match the `pom.xml`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3676687719


##########
pom.xml:
##########
@@ -96,12 +96,8 @@ under the License.
 
     <project.build.outputTimestamp>2026-01-27T00:46:35Z</project.build.outputTimestamp>
 
-    <!-- TODO remove with next parent -->
-    <maven4x.site.path>plugins-archives/${project.artifactId}-LATEST-4.x</maven4x.site.path>
-    <version.maven-compiler-plugin>3.14.1</version.maven-compiler-plugin>
-    <version.maven-dependency-plugin>3.9.0</version.maven-dependency-plugin>
-    <version.maven-invoker-plugin>3.9.1</version.maven-invoker-plugin>
     <!-- 4.x publish -->
+    <maven4x.site.path>plugins-archives/${project.artifactId}-LATEST-4.x</maven4x.site.path>
     <maven.site.path>${maven4x.site.path}</maven.site.path>
 

Review Comment:
   this can be changed to: `maven.site.path.suffix`
   https://maven.apache.org/pom/maven/#site-publication



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3684158345


##########
pom.xml:
##########
@@ -96,12 +96,8 @@ under the License.
 
     <project.build.outputTimestamp>2026-01-27T00:46:35Z</project.build.outputTimestamp>
 
-    <!-- TODO remove with next parent -->
-    <maven4x.site.path>plugins-archives/${project.artifactId}-LATEST-4.x</maven4x.site.path>
-    <version.maven-compiler-plugin>3.14.1</version.maven-compiler-plugin>
-    <version.maven-dependency-plugin>3.9.0</version.maven-dependency-plugin>
-    <version.maven-invoker-plugin>3.9.1</version.maven-invoker-plugin>
     <!-- 4.x publish -->
+    <maven4x.site.path>plugins-archives/${project.artifactId}-LATEST-4.x</maven4x.site.path>
     <maven.site.path>${maven4x.site.path}</maven.site.path>
 

Review Comment:
   Will apply the proposed changes in a separated commit. In particular, I would need to test the suffix one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3676676626


##########
pom.xml:
##########


Review Comment:
   We also should use `javaVersion` here 
   https://maven.apache.org/pom/asf/
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3684218655


##########
pom.xml:
##########


Review Comment:
   Will apply in a future commit, I need a little bit of time for testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3675351045


##########
src/it/multirelease-patterns/singleproject-toolchains/invoker.properties:
##########
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 invoker.goals = verify -Pmulti-jar
-invoker.toolchain.jdk.version=1.9
+invoker.toolchain.jdk.version=1.8

Review Comment:
   @elharo : the problem is that I don't know if this property means to run the test with the specified Java version, or if the specified Java version must be available. The `pom.xml` seems to expect a JDK 8 to be available.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux merged PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3675302675


##########
src/it/multirelease-patterns/singleproject-toolchains/invoker.properties:
##########
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 invoker.goals = verify -Pmulti-jar
-invoker.toolchain.jdk.version=1.9
+invoker.toolchain.jdk.version=1.8

Review Comment:
   This IT lives under `multirelease-patterns`, where building/verifying multi-release JAR behavior typically requires JDK 9+ (multi-release JAR support was introduced in Java 9). Changing the invoker toolchain from `1.9` to `1.8` is likely to either break the test or make it exercise the wrong behavior. Consider keeping it at a 9+ toolchain (e.g., `9` / `1.9`) unless the test is explicitly intended to run on JDK 8 only, in which case the test directory/name/profile should be adjusted to reflect that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3675601772


##########
src/it/multirelease-patterns/singleproject-toolchains/invoker.properties:
##########
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 invoker.goals = verify -Pmulti-jar
-invoker.toolchain.jdk.version=1.9
+invoker.toolchain.jdk.version=1.8

Review Comment:
   Ok, I removed the `invoker.toolchain.jdk.version` change. I verified that no matter if we set the Java version to 8 ot 9, the test is skipped anyway, both locally on my machine and in GitHub action.
   
   As it stands today, the `it/multirelease-patterns/singleproject-toolchains` test is useless and should be either removed or changed into something which is actually executed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove version numbers of plugins inherited from parent pom.xml [maven-compiler-plugin]

Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on code in PR #1097:
URL: https://github.com/apache/maven-compiler-plugin/pull/1097#discussion_r3681665406


##########
pom.xml:
##########
@@ -96,12 +96,8 @@ under the License.
 
     <project.build.outputTimestamp>2026-01-27T00:46:35Z</project.build.outputTimestamp>
 
-    <!-- TODO remove with next parent -->
-    <maven4x.site.path>plugins-archives/${project.artifactId}-LATEST-4.x</maven4x.site.path>
-    <version.maven-compiler-plugin>3.14.1</version.maven-compiler-plugin>
-    <version.maven-dependency-plugin>3.9.0</version.maven-dependency-plugin>
-    <version.maven-invoker-plugin>3.9.1</version.maven-invoker-plugin>
     <!-- 4.x publish -->
+    <maven4x.site.path>plugins-archives/${project.artifactId}-LATEST-4.x</maven4x.site.path>
     <maven.site.path>${maven4x.site.path}</maven.site.path>
 

Review Comment:
   Would the following be a replacement for both `<maven4x.site.pat>` and `<maven.site.path>`? In particular, would it include the `plugins-archives` part ?
   
   ```xml
   <maven.site.path.suffix>LATEST-4.x</maven.site.path.suffix>
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org