[GitHub] [cloudstack] anuragaw commented on a change in pull request #3430: server: fix the subnet overlap checking logic for tagged and untagged vlans when adding ipranges

[GitBox <gi...@apache.org>]

anuragaw commented on a change in pull request #3430: server: fix the subnet overlap checking logic for tagged and untagged vlans when adding ipranges
URL: https://github.com/apache/cloudstack/pull/3430#discussion_r304860581
 
 

 ##########
 File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -3581,9 +3562,29 @@ public Vlan createVlanAndPublicIpRange(final long zoneId, final long networkId,
                     if (!NetUtils.is31PrefixCidr(newCidr)) {
                         if (NetUtils.ipRangesOverlap(startIP, endIP, otherVlanStartIP, otherVlanEndIP)) {
                             throw new InvalidParameterValueException("The IP range already has IPs that overlap with the new range." +
-                                " Please specify a different start IP/end IP.");
+                                    " Please specify a different start IP/end IP.");
                         }
                     }
+                } else {
+                    // For tagged or non-overlapping URIs we need to ensure there is no Public traffic type
+                    boolean overlapped = false;
+                    if( network.getTrafficType() == TrafficType.Public ) {
 
 Review comment:
   Do you mean ` if( network.getTrafficType()....` should be reformatted to ` if (network.getTrafficType()....`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services