[GitHub] [shardingsphere] sandynz commented on a diff in pull request #25608: Add test fields for openGauss/PostgreSQL at pipeline E2E

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #25608:
URL: https://github.com/apache/shardingsphere/pull/25608#discussion_r1192170537


##########
test/e2e/operation/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/task/E2EIncrementalTask.java:
##########
@@ -53,6 +56,11 @@ public final class E2EIncrementalTask extends BaseIncrementTask {
     private static final List<String> POSTGRESQL_COLUMN_NAMES = Arrays.asList("order_id", "user_id", "status", "t_int2", "t_numeric", "t_bool", "t_bytea", "t_char", "t_varchar", "t_float",
             "t_double", "t_json", "t_jsonb", "t_text", "t_date", "t_time", "t_timestamp", "t_timestamptz");
     
+    private static final List<String> OPENGAUSS_COLUMN_NAMES = Arrays.asList("order_id", "user_id", "status", "int_column", "smallint_column", "float_column", "double_column", "numeric_column",
+            "boolean_column", "char_column", "text_column", "bytea_column", "date_column", "time_column", "smalldatetime_column", "timestamp_column", "timestamptz_column", "interval_column",
+            "array_column", "json_column", "jsonb_column", "uuid_column", "hash32_column", "tsvector_column", "bit_column", "int4range_column", "reltime_column", "abstime_column", "point_column",
+            "lseg_column", "box_column", "circle_column", "bitvarying_column", "cidr_column", "inet_column", "macaddr_column", "hll_column");

Review Comment:
   It's better to rename column name `xxx_column` to `c_xxx`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org