You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/01/11 21:31:00 UTC

[jira] [Commented] (ASTERIXDB-2688) Task is used after it has finished

    [ https://issues.apache.org/jira/browse/ASTERIXDB-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013577#comment-17013577 ] 

ASF subversion and git services commented on ASTERIXDB-2688:
------------------------------------------------------------

Commit b893514525f94e9a7688efc16ad35bf2bd6d5f95 in asterixdb's branch refs/heads/master from Ali Alsuliman
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=b893514 ]

[ASTERIXDB-2688][HYR] Fix use of a Hyracks task across join stages

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
In hash join, a task from the build stage is being used in the probe stage.
This is a problem since such tasks have already finished and notified the CC they are done.
One observed issue is related to issuing a warning in the probe phase where some warnings are
not reported because they are issued to tasks that have finished (the way this happened is that
a comparator was created in the build phase using the build-phase task. Then, this comparator
was used in the probe phase and issued a warning).

- make IHyracksJobletContext extend IHyracksCommonContext so that it is also a frame manager context
- make activites of join operators use the joblet context instead of the task context for acquiring buffers
- create the probe-to-build comparator in the probe phase so that the right task is used in the comparator

Change-Id: I38a4a779b9620494f15606162f0f1e9487fd0984
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4563
Reviewed-by: Ali Alsuliman <al...@gmail.com>
Reviewed-by: Murtadha Hubail <mh...@apache.org>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Michael Blow <mb...@apache.org>


> Task is used after it has finished
> ----------------------------------
>
>                 Key: ASTERIXDB-2688
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2688
>             Project: Apache AsterixDB
>          Issue Type: Bug
>          Components: HYR - Hyracks
>    Affects Versions: 0.9.4
>            Reporter: Ali Alsuliman
>            Assignee: Ali Alsuliman
>            Priority: Major
>             Fix For: 0.9.4.2
>
>
> In hash join, a task from the build stage is being used in the probe stage. This is a problem since such tasks have already finished and notified the CC they are done.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)