You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/26 12:35:57 UTC
[GitHub] [kafka] cadonna commented on a diff in pull request #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed
cadonna commented on code in PR #12687:
URL: https://github.com/apache/kafka/pull/12687#discussion_r979978529
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -84,7 +84,7 @@ public Collection<StandbyTask> getUpdatingStandbyTasks() {
.collect(Collectors.toList());
}
- public boolean onlyStandbyTasksLeft() {
+ private boolean onlyStandbyTasksUpdating() {
Review Comment:
I gave this method a more meaningful name and restricted access to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org