You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/10 23:30:30 UTC

[PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

rusackas opened a new pull request, #40955:
URL: https://github.com/apache/superset/pull/40955

   ### SUMMARY
   
   When a chart is updated with *only* a `query_context` (the
   `{query_context, query_context_generation}` payload that report and alert
   workers use to refresh a chart's cached payload), `UpdateChartCommand`
   intentionally skips the ownership check so those background workers can save
   context without owning the chart.
   
   This change keeps that payload internally consistent: before saving, it
   validates that the submitted `query_context.datasource` still references the
   chart's own persisted `datasource_id` (and type). A payload that points at a
   different datasource is rejected with a 400 rather than being stored as-is.
   Payloads that don't carry a parseable `datasource` are unchanged — at execution
   time they already fall back to the chart's own datasource — so there's no
   behavior change for the normal save flow.
   
   It's a small, well-scoped robustness check on the chart update path so a
   chart's stored query context can't drift away from the chart's actual
   datasource.
   
   ### TESTING INSTRUCTIONS
   
   Unit tests added in `tests/unit_tests/commands/chart/update_test.py`:
   
   - a query context targeting the chart's own datasource is accepted
   - a query context referencing a different datasource id/type is rejected
     (`ChartInvalidError` → 400), including the id-as-string case
   - payloads with no datasource / null datasource / unparseable JSON are left
     alone (no false positives)
   
   ```
   pytest tests/unit_tests/commands/chart/update_test.py
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4927819355

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4675685459

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40955:
URL: https://github.com/apache/superset/pull/40955#discussion_r3408034219


##########
superset/commands/chart/exceptions.py:
##########
@@ -103,6 +103,19 @@ def __init__(self) -> None:
         )
 
 
+class ChartQueryContextDatasourceMismatchValidationError(ValidationError):
+    """
+    Raised when a query-context-only update carries a datasource that does not
+    match the chart's own datasource.
+    """
+
+    def __init__(self) -> None:
+        super().__init__(
+            _("The query context datasource does not match the chart datasource"),
+            field_name="query_context",
+        )

Review Comment:
   **Suggestion:** Add an inline docstring to the newly added initializer method so the new function is documented consistently with the rule for new Python functions. [custom_rule]
   
   **Severity Level:** Minor ⚠️
   <details>
   <summary><b>Why it matters? 🤔 </b></summary>
   
   This is a newly added Python method, and it has no docstring. The custom rule requires new Python functions and classes to be documented inline, so the suggestion identifies a real violation.
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=858260d1e2e64c3db5a7557f5e6db588&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=858260d1e2e64c3db5a7557f5e6db588&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/commands/chart/exceptions.py
   **Line:** 112:116
   **Comment:**
   	*Custom Rule: Add an inline docstring to the newly added initializer method so the new function is documented consistently with the rule for new Python functions.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40955&comment_hash=7a235e0f15a3a4d8a7703c888e9c7b9a1c96a607304026e4eecb1fe62fc303c8&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40955&comment_hash=7a235e0f15a3a4d8a7703c888e9c7b9a1c96a607304026e4eecb1fe62fc303c8&reaction=dislike'>👎</a>



##########
tests/unit_tests/commands/chart/update_test.py:
##########
@@ -151,3 +152,76 @@ def test_update_chart_owner_can_perform_regular_update(
 
     find_by_id.assert_called_once_with(1)
     raise_for_ownership.assert_called_once()
+
+
+def _query_context_payload(datasource: object) -> dict[str, object]:
+    return {
+        "query_context": json.dumps({"datasource": datasource, "queries": []}),
+        "query_context_generation": True,
+    }

Review Comment:
   **Suggestion:** Add an inline docstring to this newly added helper function describing that it builds a query-context update payload for tests. [custom_rule]
   
   **Severity Level:** Minor ⚠️
   <details>
   <summary><b>Why it matters? 🤔 </b></summary>
   
   This is a newly added Python function in the PR and it has no docstring. The custom rule requires newly added functions and classes to be documented inline, so the suggestion correctly identifies a real violation.
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=90a7d669f73144c4a9fea2e87ad560db&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=90a7d669f73144c4a9fea2e87ad560db&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** tests/unit_tests/commands/chart/update_test.py
   **Line:** 157:161
   **Comment:**
   	*Custom Rule: Add an inline docstring to this newly added helper function describing that it builds a query-context update payload for tests.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40955&comment_hash=25a94fb6ccbf437891e845517c020f7745fa12865c9746a06b9c1547b717cf46&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40955&comment_hash=25a94fb6ccbf437891e845517c020f7745fa12865c9746a06b9c1547b717cf46&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4675710781

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40955?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `15.38462%` with `22 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.52%. Comparing base ([`f79a88c`](https://app.codecov.io/gh/apache/superset/commit/f79a88c6857a9a44faade421a17aff9938be4c68?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d544bff`](https://app.codecov.io/gh/apache/superset/commit/d544bff0717888662ec1a0779b86123a5483bf67?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/40955?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/commands/chart/update.py](https://app.codecov.io/gh/apache/superset/pull/40955?src=pr&el=tree&filepath=superset%2Fcommands%2Fchart%2Fupdate.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvY2hhcnQvdXBkYXRlLnB5) | 8.69% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40955?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/commands/chart/exceptions.py](https://app.codecov.io/gh/apache/superset/pull/40955?src=pr&el=tree&filepath=superset%2Fcommands%2Fchart%2Fexceptions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvY2hhcnQvZXhjZXB0aW9ucy5weQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40955?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (f79a88c) and HEAD (d544bff). Click for more details.
   > 
   > <details><summary>HEAD has 8 uploads less than BASE</summary>
   >
   >| Flag | BASE (f79a88c) | HEAD (d544bff) |
   >|------|------|------|
   >|python|10|2|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #40955      +/-   ##
   ==========================================
   - Coverage   64.19%   55.52%   -8.67%     
   ==========================================
     Files        2655     2655              
     Lines      143925   143951      +26     
     Branches    33181    33185       +4     
   ==========================================
   - Hits        92387    79925   -12462     
   - Misses      49918    63309   +13391     
   + Partials     1620      717     -903     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.44% <15.38%> (-0.01%)` | :arrow_down: |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.03% <15.38%> (-0.01%)` | :arrow_down: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.10% <15.38%> (-18.63%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/40955/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/40955?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #40955:
URL: https://github.com/apache/superset/pull/40955#discussion_r3553568046


##########
superset/commands/chart/exceptions.py:
##########
@@ -103,6 +103,19 @@ def __init__(self) -> None:
         )
 
 
+class ChartQueryContextDatasourceMismatchValidationError(ValidationError):
+    """
+    Raised when a query-context-only update carries a datasource that does not
+    match the chart's own datasource.
+    """
+
+    def __init__(self) -> None:
+        super().__init__(
+            _("The query context datasource does not match the chart datasource"),
+            field_name="query_context",
+        )

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Missing test coverage for validation</b></div>
   <div id="fix">
   
   The new `ChartQueryContextDatasourceMismatchValidationError` exception class (lines 106-116) lacks test coverage. No tests were found for `_validate_query_context_datasource` validation in the test suite. Tests should cover: (1) mismatched datasource ID, (2) mismatched datasource type, (3) both ID and type mismatched, and (4) the bypass path when no datasource is present in query_context. Per BITO.md adaptive rule [11730], new functionality requires comprehensive unit tests covering success paths, error scenarios, validation failures, and edge cases.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #b4ad73</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #40955:
URL: https://github.com/apache/superset/pull/40955#discussion_r3408120301


##########
superset/commands/chart/update.py:
##########
@@ -101,6 +103,51 @@ def _validate_new_dashboard_access(
                 if not security_manager.is_owner(dash):
                     raise DashboardsForbiddenError()
 
+    def _validate_query_context_datasource(
+        self, exceptions: list[ValidationError]
+    ) -> None:
+        """
+        Ensure a query-context-only update keeps the chart's own datasource.
+
+        The submitted query context is only verified when it carries a parseable
+        ``datasource`` object; a payload that references a different datasource than
+        the chart's persisted one is rejected. Payloads without a datasource fall
+        back to the chart's datasource at execution time and need no check.
+        """
+        if not self._model:
+            return
+
+        raw_query_context = self._properties.get("query_context")
+        if not raw_query_context:
+            return
+
+        try:
+            query_context = json.loads(raw_query_context)
+        except (TypeError, ValueError):
+            # An unparseable payload cannot be verified or replayed; leave it for
+            # downstream handling rather than guessing at its intent.
+            return
+
+        datasource = (
+            query_context.get("datasource") if isinstance(query_context, dict) else None
+        )
+        if not isinstance(datasource, dict):
+            return
+
+        try:
+            ids_match = int(datasource["id"]) == self._model.datasource_id
+        except (KeyError, TypeError, ValueError):
+            ids_match = False
+
+        datasource_type = datasource.get("type")
+        types_match = (
+            datasource_type is None
+            or str(datasource_type) == self._model.datasource_type
+        )

Review Comment:
   Good catch - `_convert_to_model` reads `datasource["type"]` directly, so an id-only payload would blow up on replay. Now requiring `type` to be present and match.



##########
tests/unit_tests/commands/chart/update_test.py:
##########
@@ -151,3 +152,76 @@ def test_update_chart_owner_can_perform_regular_update(
 
     find_by_id.assert_called_once_with(1)
     raise_for_ownership.assert_called_once()
+
+
+def _query_context_payload(datasource: object) -> dict[str, object]:
+    return {
+        "query_context": json.dumps({"datasource": datasource, "queries": []}),
+        "query_context_generation": True,
+    }

Review Comment:
   Added a docstring to the helper.



##########
superset/commands/chart/exceptions.py:
##########
@@ -103,6 +103,19 @@ def __init__(self) -> None:
         )
 
 
+class ChartQueryContextDatasourceMismatchValidationError(ValidationError):
+    """
+    Raised when a query-context-only update carries a datasource that does not
+    match the chart's own datasource.
+    """
+
+    def __init__(self) -> None:
+        super().__init__(
+            _("The query context datasource does not match the chart datasource"),
+            field_name="query_context",
+        )

Review Comment:
   The class itself already has a docstring covering this, and the `__init__` just forwards to `super()` with no behavior of its own, so a second docstring there would be noise. Leaving as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #40955:
URL: https://github.com/apache/superset/pull/40955#discussion_r3557663066


##########
superset/commands/chart/exceptions.py:
##########
@@ -103,6 +103,19 @@ def __init__(self) -> None:
         )
 
 
+class ChartQueryContextDatasourceMismatchValidationError(ValidationError):
+    """
+    Raised when a query-context-only update carries a datasource that does not
+    match the chart's own datasource.
+    """
+
+    def __init__(self) -> None:
+        super().__init__(
+            _("The query context datasource does not match the chart datasource"),
+            field_name="query_context",
+        )

Review Comment:
   <!-- Bito Reply -->
   The reviewer's suggestion regarding missing test coverage for the validation logic is valid. While you have implemented tests for mismatched datasource IDs and types, the current test suite does not explicitly cover the scenario where a `datasource` object is provided in the `query_context` but is missing the `type` field. Adding a test case for this specific edge case will ensure the validation logic correctly rejects such payloads, preventing potential runtime errors during dashboard loading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40955:
URL: https://github.com/apache/superset/pull/40955#discussion_r3408041395


##########
superset/commands/chart/update.py:
##########
@@ -101,6 +103,51 @@ def _validate_new_dashboard_access(
                 if not security_manager.is_owner(dash):
                     raise DashboardsForbiddenError()
 
+    def _validate_query_context_datasource(
+        self, exceptions: list[ValidationError]
+    ) -> None:
+        """
+        Ensure a query-context-only update keeps the chart's own datasource.
+
+        The submitted query context is only verified when it carries a parseable
+        ``datasource`` object; a payload that references a different datasource than
+        the chart's persisted one is rejected. Payloads without a datasource fall
+        back to the chart's datasource at execution time and need no check.
+        """
+        if not self._model:
+            return
+
+        raw_query_context = self._properties.get("query_context")
+        if not raw_query_context:
+            return
+
+        try:
+            query_context = json.loads(raw_query_context)
+        except (TypeError, ValueError):
+            # An unparseable payload cannot be verified or replayed; leave it for
+            # downstream handling rather than guessing at its intent.
+            return
+
+        datasource = (
+            query_context.get("datasource") if isinstance(query_context, dict) else None
+        )
+        if not isinstance(datasource, dict):
+            return
+
+        try:
+            ids_match = int(datasource["id"]) == self._model.datasource_id
+        except (KeyError, TypeError, ValueError):
+            ids_match = False
+
+        datasource_type = datasource.get("type")
+        types_match = (
+            datasource_type is None
+            or str(datasource_type) == self._model.datasource_type
+        )

Review Comment:
   **Suggestion:** The datasource type check currently treats a missing `datasource.type` as valid, so a query-context-only update can store a datasource object with just an id. That payload later reaches query-context loading, where datasource conversion expects `type` to exist and can fail at runtime (or leave the chart with an unusable saved query context). Require `datasource.type` to be present and equal to the chart datasource type when a `datasource` object is provided. [incomplete implementation]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Dashboard datasets builder crashes on malformed chart query_context.
   - ❌ Annotations using chart.get_query_context can raise KeyError.
   - ⚠️ Charts API accepts invalid query_context without immediate error.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Update a chart via the Charts REST API `PUT /api/v1/chart/<id>` (implemented in
   `superset/charts/api.py:439`) with a JSON body containing only `query_context` and
   `query_context_generation`, where `query_context` is a JSON string like `{"datasource":
   {"id": <chart.datasource_id>}, "queries": []}` (i.e., `datasource.id` present but
   `datasource.type` omitted).
   
   2. The request JSON is validated by `ChartPutSchema` in `superset/charts/schemas.py:48-80`
   (which treats `query_context` as an arbitrary JSON string) and then passed to
   `UpdateChartCommand(pk, item).run()` in `superset/charts/api.py:439`, which calls
   `UpdateChartCommand.validate()` in `superset/commands/chart/update.py:151-197`.
   
   3. Inside `UpdateChartCommand.validate`, the payload is recognized as a query-context-only
   update by `is_query_context_update` (`superset/commands/chart/update.py:51-54`), so
   ownership is relaxed and `_validate_query_context_datasource` is invoked; there, the code
   at `superset/commands/chart/update.py:137-146` computes `ids_match = int(datasource["id"])
   == self._model.datasource_id` and then `datasource_type = datasource.get("type")` followed
   by `types_match = (datasource_type is None or str(datasource_type) ==
   self._model.datasource_type)`, so a `datasource` dict with a matching `id` but missing
   `type` (`datasource_type is None`) is treated as valid and no
   `ChartQueryContextDatasourceMismatchValidationError` is added to `exceptions`.
   
   4. Later, when a dashboard containing this chart is loaded,
   `Dashboard.datasets_trimmed_for_slices` in `superset/models/dashboard.py:1-19` calls
   `datasource.data_for_slices(list(slices))`, which in the SqlaTable implementation
   (`superset/connectors/sqla/models.py:6-77`) calls `slc.get_query_context()` for each
   slice; `Slice.get_query_context` (`superset/models/slice.py:7-16`) does
   `json.loads(self.query_context)` and passes the resulting dict (containing
   `datasource={"id": <id>}` but no `type`) into `QueryContextFactory.create`
   (`superset/common/query_context_factory.py:7-68`), whose `_convert_to_model` at
   `superset/common/query_context_factory.py:70-74` accesses `datasource["type"]` directly;
   because `type` is missing, this raises `KeyError`, which is not caught by
   `get_query_context` or `data_for_slices`, causing a runtime error when loading the
   dashboard or any other code path that calls `Slice.get_query_context()` on the affected
   chart.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=04db5bf4bcfc42268a2409ff485ed3b5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=04db5bf4bcfc42268a2409ff485ed3b5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/commands/chart/update.py
   **Line:** 142:146
   **Comment:**
   	*Incomplete Implementation: The datasource type check currently treats a missing `datasource.type` as valid, so a query-context-only update can store a datasource object with just an id. That payload later reaches query-context loading, where datasource conversion expects `type` to exist and can fail at runtime (or leave the chart with an unusable saved query context). Require `datasource.type` to be present and equal to the chart datasource type when a `datasource` object is provided.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40955&comment_hash=1f49f583974ca205d7602eec50b50b6145fc133ef25863554d57e5b515947672&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40955&comment_hash=1f49f583974ca205d7602eec50b50b6145fc133ef25863554d57e5b515947672&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #40955:
URL: https://github.com/apache/superset/pull/40955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4968516107

   Thanks @rebenitez1802, appreciate the dig. On the UUID concern: checked it and it's not reachable today. `DatasourceKey` on the frontend always `parseInt`s the id before it goes into `query_context.datasource`, and the MCP `update_chart` tool clears `query_context` entirely rather than submitting a raw payload with one. So nothing in the codebase currently sends a UUID string through this path, though it'd need a resolve-by-UUID fallback here if that ever changes.
   
   Also added a comment clarifying the TypeError/ValueError split for the unparseable-payload case, plus tests for a non-table datasource type and a non-numeric id, since those weren't covered before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4699144346

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #40955:
URL: https://github.com/apache/superset/pull/40955#discussion_r3557661273


##########
superset/commands/chart/exceptions.py:
##########
@@ -103,6 +103,19 @@ def __init__(self) -> None:
         )
 
 
+class ChartQueryContextDatasourceMismatchValidationError(ValidationError):
+    """
+    Raised when a query-context-only update carries a datasource that does not
+    match the chart's own datasource.
+    """
+
+    def __init__(self) -> None:
+        super().__init__(
+            _("The query context datasource does not match the chart datasource"),
+            field_name="query_context",
+        )

Review Comment:
   Those cases are already covered in `update_test.py` — `test_update_chart_query_context_mismatched_datasource_is_rejected` parametrizes id, type, and missing-type mismatches, and `..._without_datasource_is_allowed` covers the bypass path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "rebenitez1802 (via GitHub)" <gi...@apache.org>.
rebenitez1802 commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4971736749

   Approve — all three points from my earlier pass are addressed in `5b5c9b9`. Nice iteration.
   
   Resolved:
   - **Medium (UUID id rejection):** you've made this a deliberate fail-closed decision rather than a bug — `test_update_chart_query_context_mismatched_datasource_is_rejected` now codifies a non-numeric id as a rejected mismatch. That's the right call for a background-worker path: a UUID that *can't* be verified against the chart's integer `datasource_id` produces a visible 400 instead of silently letting the stored context drift. Good tradeoff.
   - **Low (non-string `query_context`):** the expanded `except (TypeError, ValueError)` comment now clearly separates the "not a string / already-parsed dict, intentionally out of scope" case from the "unparseable string" case. 👍
   - **Low (test gaps):** matching test now parametrizes a non-`table` (`query`) type, and the rejection test covers the non-numeric id. Coverage matches the guarantee.
   
   🟢 Low (non-blocking) — the `"5f7b3c1a-...-uuid"` fixture isn't a syntactically valid UUID, so the comment `# non-numeric id` is more accurate than "uuid"; the code path (`int()` → `ValueError`) is identical either way, so no functional impact. Fine to leave as-is.
   
   No blocking issues. LGTM once CI is green.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40955:
URL: https://github.com/apache/superset/pull/40955#discussion_r3408121012


##########
superset/commands/chart/exceptions.py:
##########
@@ -103,6 +103,19 @@ def __init__(self) -> None:
         )
 
 
+class ChartQueryContextDatasourceMismatchValidationError(ValidationError):
+    """
+    Raised when a query-context-only update carries a datasource that does not
+    match the chart's own datasource.
+    """
+
+    def __init__(self) -> None:
+        super().__init__(
+            _("The query context datasource does not match the chart datasource"),
+            field_name="query_context",
+        )

Review Comment:
   ✅ **Customized review instruction saved!**
   
   **Instruction:**
   > Do not require an additional docstring for trivial `__init__` methods that only forward to `super()` and add no behavior of their own; the enclosing class docstring is sufficient.
   
   **Applied to:**
     - `**/*.py`
   
   ---
   💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)*



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "rebenitez1802 (via GitHub)" <gi...@apache.org>.
rebenitez1802 commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4960183599

   Approve with one question: well-scoped, well-tested defensive check with a sound rationale — mergeable as-is, pending confirmation that query-context datasource ids are always integers.
   
   **What it does:** On a query-context-only chart update (the relaxed-auth path used by report/alert workers, which skips editorship), `_validate_query_context_datasource` rejects a payload whose `query_context.datasource` points at an id/type other than the chart's own `datasource_id`/`datasource_type`. This keeps the stored query context from drifting away from — or being repointed at — a datasource the caller may not otherwise be entitled to, while leaving datasource-less payloads untouched (they fall back to the chart's own datasource at execution). Scoping is correct: it only runs in the `else` branch of `validate()`, so trusted editors on the normal path are unaffected.
   
   🟡 Medium — UUID datasource references would be wrongly rejected
   `update.py` compares with `int(datasource["id"]) == self._model.datasource_id`, but `query_context_factory._convert_to_model` → `DatasourceDAO.get_datasource` explicitly accept a UUID string as the datasource id (`database_id_or_uuid`, `daos/datasource.py:68-73`). A query context that references the chart's own datasource by UUID makes `int()` raise `ValueError` → `ids_match = False` → a valid payload gets a 400. If query contexts in practice only ever carry integer datasource ids this is theoretical; if not, it's a regression. Fix (if applicable): when `datasource["id"]` isn't an int, resolve/compare against the datasource's UUID, and add a UUID test case.
   
   🟢 Low — Non-string `query_context` silently skips the check
   `json.loads(raw_query_context)` catches `TypeError`, so an already-parsed `dict` (rather than a JSON string) is silently skipped. Fine given the schema serializes it as a string, but the `except (TypeError, ValueError): return` conflates "unparseable string" with "wrong Python type" — worth a one-line comment noting the dict case is intentionally out of scope here.
   
   🟢 Low — Test gap for the hardening claim
   The parametrized tests cover matching, id/type mismatch, string-id, missing-type, and no-datasource/null/unparseable well. Missing: a UUID-string `datasource.id` (the Medium above) and a non-`table` datasource type — both would harden the "no false positives on valid payloads" guarantee.
   
   Worth adding to the PR body: on the relaxed-auth path this also has a mild authorization benefit (a principal with chart access but no access to datasource X can no longer stash `datasource: X` for a worker to later execute). If that's intended, stating it lets reviewers weigh it against the `SECURITY.md` role/capability matrix rather than as cosmetic drift-prevention.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4970359608

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(chart): keep query-context updates bound to the chart's datasource [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40955:
URL: https://github.com/apache/superset/pull/40955#issuecomment-4968681599

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 5b5c9b92384a3ef4fefda11cefd5863e646fe7fa |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a561d06ffc1540008f0bd1d |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40955--superset-docs-preview.netlify.app](https://deploy-preview-40955--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQwOTU1LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.IXm6Eeeq7j52OTUpd-O19CruScYgRkXC74MlPVOi8kA)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctRCsIwDIDhu-TZYgquiDfwGFnSssJsasxkY3h3-_b_D98J3fTVHR4AF5iNGi-jS92vvJB5eG_ZjsDaPO8ehJw-uhnn8KW1jq3aBpTcVz2eMmiiKUXBVArH6YaI94KzRIHfHw) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-40955--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org