[GitHub] [spark] cloud-fan edited a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch

[GitBox <gi...@apache.org>]

cloud-fan edited a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch
URL: https://github.com/apache/spark/pull/24546#issuecomment-490723477
 
 
   > The PR description just says that this avoids referring to MutableColumnarRow in the new class
   
   This avoids referring to `MutableColumnarRow` in the old class(`ColumnarBatch`), so that `ColumnarBatch` does not refer to any internal classes and can be moved to the catalyst package. The related functionality that needs `MutableColumnarRow` is moved the new class `ColumnarBatchRowView `, and the new class is internal. @rdblue please let me know if you need further explanation.
   
   @kiszk The responsibility of `ColumnarBatch` is just to carry the columnar data to Spark. We can make it an interface, but I'd image all the people will have very similar implementations. I think it's better to keep it as a class, and users can use it directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org