You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/06/28 20:26:37 UTC

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13762


Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................

IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

- Added a new doc impala_client.xml as the overview of Impala impala
  client access.

Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
---
M docs/impala.ditamap
A docs/topics/impala_client.xml
M docs/topics/impala_config_options.xml
3 files changed, 149 insertions(+), 55 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/13762/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/361/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 23:22:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................

IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

- Added a new doc impala_client.xml as the overview of Impala impala
  client access.

Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Reviewed-on: http://gerrit.cloudera.org:8080/13762
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Ho <kw...@cloudera.com>
---
M docs/impala.ditamap
A docs/topics/impala_client.xml
M docs/topics/impala_config_options.xml
3 files changed, 153 insertions(+), 55 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Ho: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/361/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 23:02:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13762

to look at the new patch set (#2).

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................

IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

- Added a new doc impala_client.xml as the overview of Impala impala
  client access.

Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
---
M docs/impala.ditamap
A docs/topics/impala_client.xml
M docs/topics/impala_config_options.xml
3 files changed, 153 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/13762/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/360/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 20:47:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13762/1/docs/topics/impala_client.xml
File docs/topics/impala_client.xml:

http://gerrit.cloudera.org:8080/#/c/13762/1/docs/topics/impala_client.xml@115
PS1, Line 115: >--accepted_client_cnxn_timeout > 0</codeph>,
> May want to add that this is in seconds.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 23:02:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13762/1/docs/topics/impala_client.xml
File docs/topics/impala_client.xml:

http://gerrit.cloudera.org:8080/#/c/13762/1/docs/topics/impala_client.xml@115
PS1, Line 115: >--accepted_client_cnxn_timeout > 0</codeph>,
May want to add that this is in seconds.



-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:39:15 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 01:25:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 )

Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/360/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4c1975721c32a78a003d91babc5d2bb90f3949
Gerrit-Change-Number: 13762
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 20:26:45 +0000
Gerrit-HasComments: No