You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/01 02:59:44 UTC

[GitHub] [spark] LuciferYang commented on a change in pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase

LuciferYang commented on a change in pull request #31667:
URL: https://github.com/apache/spark/pull/31667#discussion_r584418998



##########
File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
##########
@@ -227,6 +189,8 @@ protected void initialize(String path, List<String> columns) throws IOException
       }
     }
     this.sparkSchema = new ParquetToSparkSchemaConverter(config).convert(requestedSchema);
+    // unfortunately we'd have to create the reader again since there is no column projection
+    // in the new API.
     this.reader = new ParquetFileReader(

Review comment:
       Can we reuse the `ParquetFileReader ` create at line 166 and manual  set `requestedSchema ` ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org