[GitHub] [pinot] navina commented on pull request #10702: Support Deletes In Upserts

["navina (via GitHub)" <gi...@apache.org>]

navina commented on PR #10702:
URL: https://github.com/apache/pinot/pull/10702#issuecomment-1528967707

   > This won't work. We need to keep 2 bitmaps, one for valid docs and one for queryable docs. If we only keep valid docs, and count delete as removing it from the valid doc, the next event won't work as expected because we lost track of the delete event.
   
   This is precisely what we realized during our previous attempt (https://github.com/apache/pinot/pull/10035) . Your solution isn't any different from what was attempted before. 
   
   @atris : You had reached out to me via DM (on slack) to collaborate and agreed to review the existing design. Yet, you went  ahead and did your own work. This is duplicated effort and not setting the right standard for committers of the Apache Pinot project. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org