[jira] [Commented] (HIVEMALL-268) train_ffm(features,label) causes NPE while train_ffm(features,label,'') works fine

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVEMALL-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943297#comment-16943297 ] 

ASF GitHub Bot commented on HIVEMALL-268:
-----------------------------------------

myui commented on pull request #200: [HIVEMALL-268] Fix the default vInit, eta initialization bug in FactorizationMachines
URL: https://github.com/apache/incubator-hivemall/pull/200
 
 
   ## What changes were proposed in this pull request?
   
   Fix the default vInit, eta initialization bug in FactorizationMachines
   
   ## What type of PR is it?
   
   Bug Fix
   
   ## What is the Jira issue?
   
   https://issues.apache.org/jira/browse/HIVEMALL-268
   
   ## How was this patch tested?
   
   unit tests, manual tests on EMR
   
   ## Checklist
   
   (Please remove this section if not needed; check `x` for YES, blank for NO)
   
   - [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit?
   - [ ] Did you run system tests on Hive (or Spark)?
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> train_ffm(features,label) causes NPE while train_ffm(features,label,'') works fine
> ----------------------------------------------------------------------------------
>
>                 Key: HIVEMALL-268
>                 URL: https://issues.apache.org/jira/browse/HIVEMALL-268
>             Project: Hivemall
>          Issue Type: Bug
>    Affects Versions: 0.5.2
>            Reporter: Makoto Yui
>            Assignee: Makoto Yui
>            Priority: Critical
>             Fix For: 0.6.0
>
>
> train_ffm(features,label) causes NPE while train_ffm(features,label,'') works fine.
> {code:java}
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Exception caused in the 1-th call of train()
> 	at hivemall.fm.FactorizationMachineUDTF.train(FactorizationMachineUDTF.java:404)
> 	at hivemall.fm.FactorizationMachineUDTF.process(FactorizationMachineUDTF.java:314)
> 	at org.apache.hadoop.hive.ql.exec.UDTFOperator.processOp(UDTFOperator.java:107)
> 	at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:793)
> 	at org.apache.hadoop.hive.ql.exec.SelectOperator.processOp(SelectOperator.java:87)
> 	at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:793)
> 	at org.apache.hadoop.hive.ql.exec.ExtractOperator.processOp(ExtractOperator.java:45)
> 	at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.reduce(ExecReducer.java:262)
> 	... 11 more
> Caused by: java.lang.NullPointerException
> 	at hivemall.fm.FactorizationMachineModel.initV(FactorizationMachineModel.java:391)
> 	at hivemall.fm.FFMStringFeatureMapModel.getV(FFMStringFeatureMapModel.java:152)
> 	at hivemall.fm.FieldAwareFactorizationMachineModel.predict(FieldAwareFactorizationMachineModel.java:98)
> 	at hivemall.fm.FieldAwareFactorizationMachineUDTF.trainTheta(FieldAwareFactorizationMachineUDTF.java:195)
> 	at hivemall.fm.FactorizationMachineUDTF.train(FactorizationMachineUDTF.java:401)
> 	... 18 more 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)