You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/12/09 22:30:47 UTC
Review Request 28872: Improving quota check message in the client.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Bugs: AURORA-469
https://issues.apache.org/jira/browse/AURORA-469
Repository: aurora
Description
-------
A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
Diffs
-----
src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
Diff: https://reviews.apache.org/r/28872/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/api:quota_check
Vagrant:
```
$ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
INFO]
INFO]
INFO] Updating job: hello
INFO] Not enough quota to create/update job.
INFO] Total allocated quota for www-data:
CPU 2.0
RAM 2.000000 GB
Disk 2.000000 GB
INFO] Consumed quota for www-data:
CPU 1.9
RAM 1.125977 GB
Disk 1.125000 GB
INFO] Requested for hello:
CPU 9.1
RAM 0.000000 GB
Disk 0.000000 GB
INFO] Additional quota required for www-data:
CPU 9.0
RAM 0.000000 GB
Disk 0.000000 GB
Update failed due to error:
Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
Error executing command: Update failed due to error:
```
Thanks,
Maxim Khutornenko
Re: Review Request 28872: Improving quota check message in the client.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review65986
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Dec. 10, 2014, 6:55 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28872/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 6:55 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-469
> https://issues.apache.org/jira/browse/AURORA-469
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
> src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
>
> Diff: https://reviews.apache.org/r/28872/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:quota_check
>
> Vagrant:
> ```
> $ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> INFO]
> INFO]
> INFO] Updating job: hello
> INFO] Not enough quota to create/update job.
> INFO] Total allocated quota for www-data:
> CPU 2.0
> RAM 2.000000 GB
> Disk 2.000000 GB
> INFO] Consumed quota for www-data:
> CPU 1.9
> RAM 1.125977 GB
> Disk 1.125000 GB
> INFO] Requested for hello:
> CPU 9.1
> RAM 0.000000 GB
> Disk 0.000000 GB
> INFO] Additional quota required for www-data:
> CPU 9.0
> RAM 0.000000 GB
> Disk 0.000000 GB
> Update failed due to error:
> Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
> Error executing command: Update failed due to error:
> ```
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28872: Improving quota check message in the client.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64676
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Dec. 10, 2014, 6:55 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28872/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 6:55 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-469
> https://issues.apache.org/jira/browse/AURORA-469
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
> src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
>
> Diff: https://reviews.apache.org/r/28872/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:quota_check
>
> Vagrant:
> ```
> $ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> INFO]
> INFO]
> INFO] Updating job: hello
> INFO] Not enough quota to create/update job.
> INFO] Total allocated quota for www-data:
> CPU 2.0
> RAM 2.000000 GB
> Disk 2.000000 GB
> INFO] Consumed quota for www-data:
> CPU 1.9
> RAM 1.125977 GB
> Disk 1.125000 GB
> INFO] Requested for hello:
> CPU 9.1
> RAM 0.000000 GB
> Disk 0.000000 GB
> INFO] Additional quota required for www-data:
> CPU 9.0
> RAM 0.000000 GB
> Disk 0.000000 GB
> Update failed due to error:
> Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
> Error executing command: Update failed due to error:
> ```
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28872: Improving quota check message in the client.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Dec. 11, 2014, 3:57 a.m., Aurora ReviewBot wrote:
> > Master (2aac148) is green with this patch.
> > ./build-support/jenkins/build.sh
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Ping, Kevin.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64683
-----------------------------------------------------------
On Dec. 11, 2014, 2:55 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28872/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 2:55 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-469
> https://issues.apache.org/jira/browse/AURORA-469
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
> src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
>
> Diff: https://reviews.apache.org/r/28872/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:quota_check
>
> Vagrant:
> ```
> $ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> INFO]
> INFO]
> INFO] Updating job: hello
> INFO] Not enough quota to create/update job.
> INFO] Total allocated quota for www-data:
> CPU 2.0
> RAM 2.000000 GB
> Disk 2.000000 GB
> INFO] Consumed quota for www-data:
> CPU 1.9
> RAM 1.125977 GB
> Disk 1.125000 GB
> INFO] Requested for hello:
> CPU 9.1
> RAM 0.000000 GB
> Disk 0.000000 GB
> INFO] Additional quota required for www-data:
> CPU 9.0
> RAM 0.000000 GB
> Disk 0.000000 GB
> Update failed due to error:
> Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
> Error executing command: Update failed due to error:
> ```
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28872: Improving quota check message in the client.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64683
-----------------------------------------------------------
Ship it!
Master (2aac148) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 11, 2014, 2:55 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28872/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 2:55 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-469
> https://issues.apache.org/jira/browse/AURORA-469
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
> src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
>
> Diff: https://reviews.apache.org/r/28872/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:quota_check
>
> Vagrant:
> ```
> $ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> INFO]
> INFO]
> INFO] Updating job: hello
> INFO] Not enough quota to create/update job.
> INFO] Total allocated quota for www-data:
> CPU 2.0
> RAM 2.000000 GB
> Disk 2.000000 GB
> INFO] Consumed quota for www-data:
> CPU 1.9
> RAM 1.125977 GB
> Disk 1.125000 GB
> INFO] Requested for hello:
> CPU 9.1
> RAM 0.000000 GB
> Disk 0.000000 GB
> INFO] Additional quota required for www-data:
> CPU 9.0
> RAM 0.000000 GB
> Disk 0.000000 GB
> Update failed due to error:
> Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
> Error executing command: Update failed due to error:
> ```
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28872: Improving quota check message in the client.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 2:55 a.m.)
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Bugs: AURORA-469
https://issues.apache.org/jira/browse/AURORA-469
Repository: aurora
Description
-------
A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
Diff: https://reviews.apache.org/r/28872/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/api:quota_check
Vagrant:
```
$ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
INFO]
INFO]
INFO] Updating job: hello
INFO] Not enough quota to create/update job.
INFO] Total allocated quota for www-data:
CPU 2.0
RAM 2.000000 GB
Disk 2.000000 GB
INFO] Consumed quota for www-data:
CPU 1.9
RAM 1.125977 GB
Disk 1.125000 GB
INFO] Requested for hello:
CPU 9.1
RAM 0.000000 GB
Disk 0.000000 GB
INFO] Additional quota required for www-data:
CPU 9.0
RAM 0.000000 GB
Disk 0.000000 GB
Update failed due to error:
Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
Error executing command: Update failed due to error:
```
Thanks,
Maxim Khutornenko
Re: Review Request 28872: Improving quota check message in the client.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 2:54 a.m.)
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Changes
-------
CR comments.
Bugs: AURORA-469
https://issues.apache.org/jira/browse/AURORA-469
Repository: aurora
Description
-------
A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
Diff: https://reviews.apache.org/r/28872/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/api:quota_check
Vagrant:
```
$ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
INFO]
INFO]
INFO] Updating job: hello
INFO] Not enough quota to create/update job.
INFO] Total allocated quota for www-data:
CPU 2.0
RAM 2.000000 GB
Disk 2.000000 GB
INFO] Consumed quota for www-data:
CPU 1.9
RAM 1.125977 GB
Disk 1.125000 GB
INFO] Requested for hello:
CPU 9.1
RAM 0.000000 GB
Disk 0.000000 GB
INFO] Additional quota required for www-data:
CPU 9.0
RAM 0.000000 GB
Disk 0.000000 GB
Update failed due to error:
Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
Error executing command: Update failed due to error:
```
Thanks,
Maxim Khutornenko
Re: Review Request 28872: Improving quota check message in the client.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64441
-----------------------------------------------------------
Ship it!
Master (9926af3) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 9, 2014, 9:30 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28872/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 9:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-469
> https://issues.apache.org/jira/browse/AURORA-469
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
> src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
>
> Diff: https://reviews.apache.org/r/28872/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:quota_check
>
> Vagrant:
> ```
> $ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> INFO]
> INFO]
> INFO] Updating job: hello
> INFO] Not enough quota to create/update job.
> INFO] Total allocated quota for www-data:
> CPU 2.0
> RAM 2.000000 GB
> Disk 2.000000 GB
> INFO] Consumed quota for www-data:
> CPU 1.9
> RAM 1.125977 GB
> Disk 1.125000 GB
> INFO] Requested for hello:
> CPU 9.1
> RAM 0.000000 GB
> Disk 0.000000 GB
> INFO] Additional quota required for www-data:
> CPU 9.0
> RAM 0.000000 GB
> Disk 0.000000 GB
> Update failed due to error:
> Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
> Error executing command: Update failed due to error:
> ```
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28872: Improving quota check message in the client.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Dec. 9, 2014, 11:41 p.m., Zameer Manji wrote:
> > src/test/python/apache/aurora/client/api/test_quota_check.py, line 124
> > <https://reviews.apache.org/r/28872/diff/1/?file=787283#file787283line124>
> >
> > Can you set all the calls to print quota?
Sure, done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64466
-----------------------------------------------------------
On Dec. 9, 2014, 9:30 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28872/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 9:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-469
> https://issues.apache.org/jira/browse/AURORA-469
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
> src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
>
> Diff: https://reviews.apache.org/r/28872/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:quota_check
>
> Vagrant:
> ```
> $ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> INFO]
> INFO]
> INFO] Updating job: hello
> INFO] Not enough quota to create/update job.
> INFO] Total allocated quota for www-data:
> CPU 2.0
> RAM 2.000000 GB
> Disk 2.000000 GB
> INFO] Consumed quota for www-data:
> CPU 1.9
> RAM 1.125977 GB
> Disk 1.125000 GB
> INFO] Requested for hello:
> CPU 9.1
> RAM 0.000000 GB
> Disk 0.000000 GB
> INFO] Additional quota required for www-data:
> CPU 9.0
> RAM 0.000000 GB
> Disk 0.000000 GB
> Update failed due to error:
> Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
> Error executing command: Update failed due to error:
> ```
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28872: Improving quota check message in the client.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64466
-----------------------------------------------------------
src/test/python/apache/aurora/client/api/test_quota_check.py
<https://reviews.apache.org/r/28872/#comment107183>
Can you set all the calls to print quota?
- Zameer Manji
On Dec. 9, 2014, 1:30 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28872/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 1:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-469
> https://issues.apache.org/jira/browse/AURORA-469
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A minor fix improving the quota check message on the client. Minor enough to consider for a dying client updater.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/quota_check.py c994050d76a9b617f70dfcbf60cf10e02d4a4bb9
> src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c
>
> Diff: https://reviews.apache.org/r/28872/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:quota_check
>
> Vagrant:
> ```
> $ aurora2 job update devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> INFO]
> INFO]
> INFO] Updating job: hello
> INFO] Not enough quota to create/update job.
> INFO] Total allocated quota for www-data:
> CPU 2.0
> RAM 2.000000 GB
> Disk 2.000000 GB
> INFO] Consumed quota for www-data:
> CPU 1.9
> RAM 1.125977 GB
> Disk 1.125000 GB
> INFO] Requested for hello:
> CPU 9.1
> RAM 0.000000 GB
> Disk 0.000000 GB
> INFO] Additional quota required for www-data:
> CPU 9.0
> RAM 0.000000 GB
> Disk 0.000000 GB
> Update failed due to error:
> Unable to start job update: Response from scheduler: INVALID_REQUEST (message: Failed quota check.)
> Error executing command: Update failed due to error:
> ```
>
>
> Thanks,
>
> Maxim Khutornenko
>
>