You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/28 18:16:10 UTC
[GitHub] [ozone] myskov opened a new pull request, #3910: HDDS-7435. ContainerOperationClient cleanup
myskov opened a new pull request, #3910:
URL: https://github.com/apache/ozone/pull/3910
## What changes were proposed in this pull request?
I did some ContainerOperationClient cleanup:
* removed unused methods
* removed duplicated javadoc comments
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7435
## How was this patch tested?
unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3910: HDDS-7435. ContainerOperationClient cleanup
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3910:
URL: https://github.com/apache/ozone/pull/3910#issuecomment-1297325738
@SaketaChalamchala @DaveTeng0 @aswinshakil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3910: HDDS-7435. ContainerOperationClient cleanup
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3910:
URL: https://github.com/apache/ozone/pull/3910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on a diff in pull request #3910: HDDS-7435. ContainerOperationClient cleanup
Posted by GitBox <gi...@apache.org>.
myskov commented on code in PR #3910:
URL: https://github.com/apache/ozone/pull/3910#discussion_r1009809141
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerOperationClient.java:
##########
@@ -259,18 +203,6 @@ public ContainerWithPipeline createContainer(HddsProtos.ReplicationType type,
}
}
- /**
Review Comment:
@aswinshakil javadocs are inherited by default. @{inheritDoc} makes sense if we extend javadoc from the parent method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3910: HDDS-7435. ContainerOperationClient cleanup
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3910:
URL: https://github.com/apache/ozone/pull/3910#issuecomment-1298357020
Thanks @myskov for the cleanup, @aswinshakil, @DaveTeng0, @hemantk-12 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on pull request #3910: HDDS-7435. ContainerOperationClient cleanup
Posted by GitBox <gi...@apache.org>.
myskov commented on PR #3910:
URL: https://github.com/apache/ozone/pull/3910#issuecomment-1298333805
As the PR has 3 approvals and all checks have passed, could you merge it, please? @aswinshakil @DaveTeng0 @hemantk-12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aswinshakil commented on pull request #3910: HDDS-7435. ContainerOperationClient cleanup
Posted by GitBox <gi...@apache.org>.
aswinshakil commented on PR #3910:
URL: https://github.com/apache/ozone/pull/3910#issuecomment-1297620024
Thanks for the explanation @myskov. I'm good with the change but it looks like some Unit Tests are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aswinshakil commented on a diff in pull request #3910: HDDS-7435. ContainerOperationClient cleanup
Posted by GitBox <gi...@apache.org>.
aswinshakil commented on code in PR #3910:
URL: https://github.com/apache/ozone/pull/3910#discussion_r1009805668
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerOperationClient.java:
##########
@@ -259,18 +203,6 @@ public ContainerWithPipeline createContainer(HddsProtos.ReplicationType type,
}
}
- /**
Review Comment:
Instead of removing it why not inherit docs from the interface? Something like this,
```
/**
* {@inheritDoc}
*/
```
Same comment for the other changes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org