You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/26 16:06:04 UTC

[GitHub] [tvm] Lunderberg commented on pull request #11129: [TIR] Reduced duplication in op.h

Lunderberg commented on PR #11129:
URL: https://github.com/apache/tvm/pull/11129#issuecomment-1109979956

   Thank you, and I like the suggestion of making the broadcast handling more explicit.  I was initially aiming for consistency and removing surprises when using similarly named APIs, and I hadn't been thinking of extracting the broadcast handling.
   
   It looks like `is_const_int` was added #1789, and handled Broadcast nodes since its initial implementation.  Glancing at the ~20 or so usages, I don't see anywhere that obviously needs handling.  For now, I'm going to convert this to a draft, remove the Broadcast handling, and use any breakage to determine where there should be `is_const_int_broadcast` checks instead of `is_const_int`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org