You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2017/07/04 18:16:44 UTC
[1/3] jclouds git commit: Correct reversed assertEquals arguments
Repository: jclouds
Updated Branches:
refs/heads/master 624e4cb6a -> 84653bac6
Correct reversed assertEquals arguments
Found via error-prone 2.0.21.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/d6ca5cb4
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/d6ca5cb4
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/d6ca5cb4
Branch: refs/heads/master
Commit: d6ca5cb42971aaaafb33e9516aff4ad4ed1a5775
Parents: 624e4cb
Author: Andrew Gaul <ga...@apache.org>
Authored: Tue Jul 4 11:14:16 2017 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Tue Jul 4 11:14:16 2017 -0700
----------------------------------------------------------------------
.../binder/datacenter/CreateDataCenterRequestBinderTest.java | 2 +-
.../binder/datacenter/UpdateDataCenterRequestBinderTest.java | 2 +-
.../binder/drive/AddRomDriveToServerRequestBinderTest.java | 2 +-
.../binder/firewall/AddFirewallRuleToNicRequestBinderTest.java | 2 +-
.../binder/loadbalancer/CreateLoadBalancerRequestBinderTest.java | 2 +-
.../loadbalancer/DeregisterLoadBalancerRequestBinderTest.java | 2 +-
.../loadbalancer/RegisterLoadBalancerRequestBinderTest.java | 2 +-
.../binder/loadbalancer/UpdateLoadBalancerRequestBinderTest.java | 2 +-
.../profitbricks/binder/nic/CreateNicRequestBinderTest.java | 2 +-
.../profitbricks/binder/nic/SetInternetAccessBinderTest.java | 2 +-
.../profitbricks/binder/nic/UpdateNicRequestBinderTest.java | 2 +-
.../binder/snapshot/CreateSnapshotRequestBinderTest.java | 2 +-
.../binder/snapshot/RollbackSnapshotRequestBinderTest.java | 2 +-
.../binder/snapshot/UpdateSnapshotRequestBinderTest.java | 2 +-
.../http/parser/ServiceFaultResponseHandlerTest.java | 4 ++--
.../parser/datacenter/DataCenterListResponseHandlerTest.java | 2 +-
.../http/parser/firewall/FirewallResponseHandlerTest.java | 2 +-
.../http/parser/image/ImageInfoResponseHandlerTest.java | 2 +-
.../http/parser/image/ImageListResponseHandlerTest.java | 2 +-
19 files changed, 20 insertions(+), 20 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/CreateDataCenterRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/CreateDataCenterRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/CreateDataCenterRequestBinderTest.java
index 5190d6f..b653ab7 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/CreateDataCenterRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/CreateDataCenterRequestBinderTest.java
@@ -34,7 +34,7 @@ public class CreateDataCenterRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/UpdateDataCenterRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/UpdateDataCenterRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/UpdateDataCenterRequestBinderTest.java
index 589fc69..99481a2 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/UpdateDataCenterRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/UpdateDataCenterRequestBinderTest.java
@@ -33,7 +33,7 @@ public class UpdateDataCenterRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/drive/AddRomDriveToServerRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/drive/AddRomDriveToServerRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/drive/AddRomDriveToServerRequestBinderTest.java
index 134b62f..d561c0d 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/drive/AddRomDriveToServerRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/drive/AddRomDriveToServerRequestBinderTest.java
@@ -34,7 +34,7 @@ public class AddRomDriveToServerRequestBinderTest {
.build();
String actual = binder.createPayload(payload);
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinderTest.java
index 0e074a6..fea3009 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinderTest.java
@@ -47,7 +47,7 @@ public class AddFirewallRuleToNicRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload = (" <ws:addFirewallRulesToNic>\n"
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/CreateLoadBalancerRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/CreateLoadBalancerRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/CreateLoadBalancerRequestBinderTest.java
index 4744986..b9afc2a 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/CreateLoadBalancerRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/CreateLoadBalancerRequestBinderTest.java
@@ -50,7 +50,7 @@ public class CreateLoadBalancerRequestBinderTest {
.build());
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinderTest.java
index c690fb3..82f5a07 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinderTest.java
@@ -35,7 +35,7 @@ public class DeregisterLoadBalancerRequestBinderTest {
"load-balancer-id", ImmutableList.of("1", "2")));
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinderTest.java
index 8f2e5a9..eead564 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinderTest.java
@@ -34,7 +34,7 @@ public class RegisterLoadBalancerRequestBinderTest {
"load-balancer-id", ImmutableList.of("1", "2")));
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/UpdateLoadBalancerRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/UpdateLoadBalancerRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/UpdateLoadBalancerRequestBinderTest.java
index b638c89..24d512d 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/UpdateLoadBalancerRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/UpdateLoadBalancerRequestBinderTest.java
@@ -46,7 +46,7 @@ public class UpdateLoadBalancerRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/CreateNicRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/CreateNicRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/CreateNicRequestBinderTest.java
index 8e2630d..645508d 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/CreateNicRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/CreateNicRequestBinderTest.java
@@ -38,7 +38,7 @@ public class CreateNicRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload = ("<ws:createNic>\n"
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/SetInternetAccessBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/SetInternetAccessBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/SetInternetAccessBinderTest.java
index c499c73..b99f125 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/SetInternetAccessBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/SetInternetAccessBinderTest.java
@@ -37,7 +37,7 @@ public class SetInternetAccessBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload = (" <ws:setInternetAccess>\n"
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/UpdateNicRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/UpdateNicRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/UpdateNicRequestBinderTest.java
index 298fea7..383d35c 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/UpdateNicRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/UpdateNicRequestBinderTest.java
@@ -39,7 +39,7 @@ public class UpdateNicRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload = (" <ws:updateNic>\n"
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinderTest.java
index 8a9c581..3de7151 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinderTest.java
@@ -37,7 +37,7 @@ public class CreateSnapshotRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/RollbackSnapshotRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/RollbackSnapshotRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/RollbackSnapshotRequestBinderTest.java
index 87a043c..ad32b58 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/RollbackSnapshotRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/RollbackSnapshotRequestBinderTest.java
@@ -32,7 +32,7 @@ public class RollbackSnapshotRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
private final String expectedPayload = "<ws:rollbackSnapshot>"
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinderTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinderTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinderTest.java
index 1809a1c..7e35455 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinderTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinderTest.java
@@ -48,7 +48,7 @@ public class UpdateSnapshotRequestBinderTest {
String actual = binder.createPayload(payload);
assertNotNull(actual, "Binder returned null payload");
- assertEquals(expectedPayload, actual);
+ assertEquals(actual, expectedPayload);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ServiceFaultResponseHandlerTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ServiceFaultResponseHandlerTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ServiceFaultResponseHandlerTest.java
index f8c36f6..2bd1e41 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ServiceFaultResponseHandlerTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ServiceFaultResponseHandlerTest.java
@@ -52,7 +52,7 @@ public class ServiceFaultResponseHandlerTest extends BaseResponseHandlerTest<Ser
"The requested resource could not be found. Please refer to Request Id : 16370720. [VDC-6-404] The requested resource does not exist or already deleted by the users. ResourceId random-non-existing-id")
.requestId(16370720).build()).build();
- assertEquals(expected, actual);
+ assertEquals(actual, expected);
}
@Test
@@ -64,6 +64,6 @@ public class ServiceFaultResponseHandlerTest extends BaseResponseHandlerTest<Ser
ServiceFault expected = ServiceFault.builder().faultCode("S:Server").faultString("javax.ejb.EJBException")
.build();
- assertEquals(expected, actual);
+ assertEquals(actual, expected);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterListResponseHandlerTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterListResponseHandlerTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterListResponseHandlerTest.java
index 7e738ae..c24be57 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterListResponseHandlerTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterListResponseHandlerTest.java
@@ -48,6 +48,6 @@ public class DataCenterListResponseHandlerTest extends BaseResponseHandlerTest<L
DataCenter.builder().id("aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee").name("JClouds-DC").version(10).state(ProvisioningState.AVAILABLE).build(),
DataCenter.builder().id("qqqqqqqq-wwww-rrrr-tttt-yyyyyyyyyyyy").name("Random DC").version(238).state(ProvisioningState.INPROCESS).build()
);
- assertEquals(expected, actual);
+ assertEquals(actual, expected);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/firewall/FirewallResponseHandlerTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/firewall/FirewallResponseHandlerTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/firewall/FirewallResponseHandlerTest.java
index eeb4cba..5777035 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/firewall/FirewallResponseHandlerTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/firewall/FirewallResponseHandlerTest.java
@@ -64,7 +64,7 @@ public class FirewallResponseHandlerTest extends BaseResponseHandlerTest<Firewal
.rules(firewallRules)
.build();
- assertEquals(expected, actual);
+ assertEquals(actual, expected);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageInfoResponseHandlerTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageInfoResponseHandlerTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageInfoResponseHandlerTest.java
index fb2e33d..70e9364 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageInfoResponseHandlerTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageInfoResponseHandlerTest.java
@@ -59,7 +59,7 @@ public class ImageInfoResponseHandlerTest extends BaseResponseHandlerTest<Image>
.isWriteable(true)
.build();
- assertEquals(expected, actual);
+ assertEquals(actual, expected);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d6ca5cb4/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageListResponseHandlerTest.java
----------------------------------------------------------------------
diff --git a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageListResponseHandlerTest.java b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageListResponseHandlerTest.java
index e954fb0..e913e46 100644
--- a/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageListResponseHandlerTest.java
+++ b/providers/profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageListResponseHandlerTest.java
@@ -178,6 +178,6 @@ public class ImageListResponseHandlerTest extends BaseResponseHandlerTest<List<I
.build()
);
- assertEquals(expected, actual);
+ assertEquals(actual, expected);
}
}
[3/3] jclouds git commit: Suppress self-comparison error-prone warning
Posted by ga...@apache.org.
Suppress self-comparison error-prone warning
We intentionally self-compare to test correctness.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/84653bac
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/84653bac
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/84653bac
Branch: refs/heads/master
Commit: 84653bac652c878db7c54e19a186ccddf61984a2
Parents: d36812e
Author: Andrew Gaul <ga...@apache.org>
Authored: Tue Jul 4 11:15:51 2017 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Tue Jul 4 11:15:51 2017 -0700
----------------------------------------------------------------------
compute/src/test/java/org/jclouds/net/domain/IpPermissionTest.java | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/84653bac/compute/src/test/java/org/jclouds/net/domain/IpPermissionTest.java
----------------------------------------------------------------------
diff --git a/compute/src/test/java/org/jclouds/net/domain/IpPermissionTest.java b/compute/src/test/java/org/jclouds/net/domain/IpPermissionTest.java
index 7f90ea4..b25b8dc 100644
--- a/compute/src/test/java/org/jclouds/net/domain/IpPermissionTest.java
+++ b/compute/src/test/java/org/jclouds/net/domain/IpPermissionTest.java
@@ -223,6 +223,7 @@ public class IpPermissionTest {
assertTrue(first.compareTo(second) == 0, first + " does not compare zero to " + second);
}
+ @SuppressWarnings("SelfComparison")
private static void assertOrder(IpPermission smaller, IpPermission bigger) {
assertTrue(smaller.compareTo(bigger) < 0, smaller + " does not compare less than " + bigger);
assertTrue(bigger.compareTo(smaller) > 0, bigger + " does not compare greater than " + smaller);
[2/3] jclouds git commit: Correct misplaced AutoValue parameters
Posted by ga...@apache.org.
Correct misplaced AutoValue parameters
Found via error-prone 2.0.21.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/d36812e5
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/d36812e5
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/d36812e5
Branch: refs/heads/master
Commit: d36812e5a66462ecaa9e6d566acedd4fe0182db9
Parents: d6ca5cb
Author: Andrew Gaul <ga...@apache.org>
Authored: Tue Jul 4 11:15:21 2017 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Tue Jul 4 11:15:21 2017 -0700
----------------------------------------------------------------------
.../digitalocean2/domain/internal/PaginatedCollection.java | 4 ++--
.../org/jclouds/googlecloudstorage/domain/ResumableUpload.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d36812e5/providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/domain/internal/PaginatedCollection.java
----------------------------------------------------------------------
diff --git a/providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/domain/internal/PaginatedCollection.java b/providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/domain/internal/PaginatedCollection.java
index 8ca7b21..b7f506d 100644
--- a/providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/domain/internal/PaginatedCollection.java
+++ b/providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/domain/internal/PaginatedCollection.java
@@ -58,8 +58,8 @@ public abstract class PaginatedCollection<T> extends IterableWithMarker<T> {
@Nullable public abstract URI last();
@SerializedNames({ "first", "prev", "next", "last" })
- public static Pages create(URI first, URI next, URI prev, URI last) {
- return new AutoValue_PaginatedCollection_Links_Pages(first, next, prev, last);
+ public static Pages create(URI first, URI prev, URI next, URI last) {
+ return new AutoValue_PaginatedCollection_Links_Pages(first, prev, next, last);
}
Pages() { }
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d36812e5/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ResumableUpload.java
----------------------------------------------------------------------
diff --git a/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ResumableUpload.java b/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ResumableUpload.java
index 556347a..212c205 100644
--- a/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ResumableUpload.java
+++ b/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ResumableUpload.java
@@ -32,10 +32,10 @@ public abstract class ResumableUpload {
@Nullable public abstract String contentLength();
- @Nullable public abstract Long rangeUpperValue();
-
@Nullable public abstract Long rangeLowerValue();
+ @Nullable public abstract Long rangeUpperValue();
+
public static ResumableUpload create(int statusCode, String uploadId, String contentLength, Long rangeLowerValue,
Long rangeUpperValue) {
return new AutoValue_ResumableUpload(statusCode, uploadId, contentLength, rangeLowerValue, rangeUpperValue);