You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/08 18:41:16 UTC

[GitHub] [arrow] lwhite1 commented on pull request #13811: ARROW-17303: [Java][Dataset] Read Arrow IPC files by NativeDatasetFactory (#13760)

lwhite1 commented on PR #13811:
URL: https://github.com/apache/arrow/pull/13811#issuecomment-1208475313

   Hi @igor-suhorukov This looks good to me except I wish the tests were more robust. (The same is true for the Parquet test that you're emulating, but I guess that's out of scope here.) 
   
   This kind of test - relying on checking sizes and names - doesn't provide much assurance that we won't see bug reports when people import complex data types or otherwise tap into some of the more advanced functionality. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org