[GitHub] michellethomas opened a new pull request #6869: Adding template_params to datasource editor for sqla tables

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #6869: Adding template_params to datasource editor for sqla tables
URL: https://github.com/apache/incubator-superset/pull/6869
 
 
   If a sqla table previously had template_params, saving changes in the datasource editor will override template_params. To fix this, I'm adding the template_params field to the "Advanced" section of the table editor.
   
   Tested by:
   Created a sqllab datasource based on birth names with jinja params.
   Edited the template_params using the datasource editor and confirmed that the param was getting updated.
   
   @mistercrunch @graceguo-supercat @john-bodley 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org