You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/08 08:38:47 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
terrymanu opened a new issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706
The current test cases are mix equals and not equals, please split them.
- [ ] Split DataSourceConfigurationTest.assertEquals to assertEquals and assertNotEquals
- [ ] Split DataSourceConfigurationTest.assertHashCode to assertSameHashCode and assertDifferentHashCode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
jian365066744 commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-670846623
please assign to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] GeniusQ commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
GeniusQ commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-670846998
让我来 ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhenpuwang commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
zhenpuwang commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-670853341
Give me a chance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia edited a comment on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
taojintianxia edited a comment on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-671736962
> liang,I have finish the task.but I find the issue #6706 is not exist,the DataSourceConfigurationTest is the issue #6718,please tell me how to do.
> 
hi , there
I checked your fork repository , but I didn't find the branch for this issue. whenever we try to commit a PR , we have to fork the original repository and then checkout a new branch . you could checkout the detail through the [DOCUMENT](https://shardingsphere.apache.org/community/cn/contribute/contributor/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
jian365066744 commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-671397539
liang,I have finish the task.but I didn't find the issue #6706 is not exist,the DataSourceConfigurationTest is the issue #6718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 edited a comment on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
jian365066744 edited a comment on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-671397539
liang,I have finish the task.but I didn't find the issue #6706 is not exist,the DataSourceConfigurationTest is the issue #6718,please tell me how to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-670847550
@jian365066744 Thank you, assigned, I add to more sub tasks, please have a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
jian365066744 commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-670850920
thanks,I am outside, I will finish the task later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
jian365066744 commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-671754038
thinks your reply and notice about how to commit the issues,I will do right in next time.thinks again.
------------------ 原始邮件 ------------------
发件人: "apache/shardingsphere" <notifications@github.com>;
发送时间: 2020年8月11日(星期二) 中午1:37
收件人: "apache/shardingsphere"<shardingsphere@noreply.github.com>;
抄送: "123"<365066744@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [apache/shardingsphere] Optimize test cases of DataSourceConfiguration.equals and hashCode (#6706)
liang,I have finish the task.but I find the issue #6706 is not exist,the DataSourceConfigurationTest is the issue #6718,please tell me how to do.
hi , there
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 edited a comment on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
jian365066744 edited a comment on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-671397539
liang,I have finish the task.but I find the issue #6706 is not exist,the DataSourceConfigurationTest is the issue #6718,please tell me how to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-671726765
@ jian365066744 What's mean the issue #6706 is not exist?
You are in the issue #6706 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on issue #6706: Optimize test cases of DataSourceConfiguration.equals and hashCode
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on issue #6706:
URL: https://github.com/apache/shardingsphere/issues/6706#issuecomment-671736962
> liang,I have finish the task.but I find the issue #6706 is not exist,the DataSourceConfigurationTest is the issue #6718,please tell me how to do.
> 
hi , there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org