You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "LeonxLJX (via GitHub)" <gi...@apache.org> on 2026/09/02 02:07:47 UTC

[PR] [DSIP-64][Master] Add workflow integration test cases for switch routed by global param and condition task with mixed predecessor states [dolphinscheduler]

LeonxLJX opened a new pull request, #18610:
URL: https://github.com/apache/dolphinscheduler/pull/18610

   ### Purpose of this PR
   Add more workflow integration test cases in master (DSIP-64, closes #16479).
   
   ### What this PR does
   1. **Switch task routed by a workflow global parameter** (`WorkflowStartSwitchByGlobalParamTestCase`): verifies that the switch condition can reference a workflow global parameter (e.g. ` == 'success'`) and routes to the expected branch. Previously the switch integration cases only used a constant condition (`true == true`), so the global-parameter injection path in `SwitchTaskUtils.generateContentWithTaskParams` was not covered end-to-end.
   2. **Condition task with mixed predecessor states** (`WorkflowStartConditionMixedPredecessorTestCase`): a condition task with an AND dependency on two predecessors (one SUCCESS, one FAILURE) must evaluate both and route to the failed branch, skipping the success branch. Previously condition cases only covered a single predecessor.
   
   ### How to verify
   \./mvnw -B -ntp -pl dolphinscheduler-master -am test -Dtest='WorkflowStartSwitchByGlobalParamTestCase,WorkflowStartConditionMixedPredecessorTestCase' -Dsurefire.failIfNoSpecifiedTests=false
   \
   ### Checklist
   - [x] The PR title starts with the module name (e.g. [Master])
   - [x] Commits follow the [commit message convention](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/commit-convention.md)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [DSIP-64][Master] Add workflow integration test cases for switch routed by global param and condition task with mixed predecessor states [dolphinscheduler]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #18610:
URL: https://github.com/apache/dolphinscheduler/pull/18610#issuecomment-5503265334

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [DSIP-64][Master] Add workflow integration test cases for switch routed by global param and condition task with mixed predecessor states [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #18610:
URL: https://github.com/apache/dolphinscheduler/pull/18610#issuecomment-5503486425

   You are blindly submitting PR using AI, and I will close this PR until you stop blindly using AI to comply with community norms.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [DSIP-64][Master] Add workflow integration test cases for switch routed by global param and condition task with mixed predecessor states [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #18610: [DSIP-64][Master] Add workflow integration test cases for switch routed by global param and condition task with mixed predecessor states
URL: https://github.com/apache/dolphinscheduler/pull/18610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org