You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/08 10:08:10 UTC
[GitHub] [shardingsphere] MingxingLAI opened a new pull request #10717: Create AbstractFederateRefresher #10714
MingxingLAI opened a new pull request #10717:
URL: https://github.com/apache/shardingsphere/pull/10717
Fixes #10714 .
Changes proposed in this pull request:
- promote common code to the abstract parent class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] MingxingLAI closed pull request #10717: Create AbstractFederateRefresher #10714
Posted by GitBox <gi...@apache.org>.
MingxingLAI closed pull request #10717:
URL: https://github.com/apache/shardingsphere/pull/10717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10717: Create AbstractFederateRefresher #10714
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #10717:
URL: https://github.com/apache/shardingsphere/pull/10717#discussion_r648054652
##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/test/java/org/apache/shardingsphere/infra/optimize/core/metadata/refresher/AlterTableStatementFederateRefresherTest.java
##########
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.optimize.core.metadata.refresher;
+
+import com.google.common.collect.ImmutableMap;
+import org.apache.shardingsphere.infra.database.type.dialect.MySQLDatabaseType;
+import org.apache.shardingsphere.infra.database.type.dialect.OracleDatabaseType;
+import org.apache.shardingsphere.infra.database.type.dialect.PostgreSQLDatabaseType;
+import org.apache.shardingsphere.infra.database.type.dialect.SQL92DatabaseType;
+import org.apache.shardingsphere.infra.database.type.dialect.SQLServerDatabaseType;
+import org.apache.shardingsphere.infra.metadata.schema.builder.SchemaBuilderMaterials;
+import org.apache.shardingsphere.infra.metadata.schema.model.ColumnMetaData;
+import org.apache.shardingsphere.infra.metadata.schema.model.IndexMetaData;
+import org.apache.shardingsphere.infra.metadata.schema.model.TableMetaData;
+import org.apache.shardingsphere.infra.optimize.core.metadata.FederateSchemaMetadata;
+import org.apache.shardingsphere.infra.optimize.core.metadata.refresher.type.AlterTableStatementFederateRefresher;
+import org.apache.shardingsphere.infra.rule.ShardingSphereRule;
+import org.apache.shardingsphere.infra.rule.type.TableContainedRule;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.SimpleTableSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.TableNameSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.AlterTableStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.ddl.MySQLAlterTableStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleAlterTableStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterTableStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.sql92.ddl.SQL92AlterTableStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.sqlserver.ddl.SQLServerAlterTableStatement;
+import org.junit.Test;
+
+import java.sql.Connection;
+import java.sql.DatabaseMetaData;
+import javax.sql.DataSource;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class AlterTableStatementFederateRefresherTest {
+
+ private final SchemaBuilderMaterials materials = mock(SchemaBuilderMaterials.class);
+
+ @Test
+ public void refreshTableWithRule() throws SQLException {
+ when(materials.getDatabaseType()).thenReturn(new MySQLDatabaseType());
+ refreshTableWithRule(new MySQLAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new OracleDatabaseType());
+ refreshTableWithRule(new OracleAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new PostgreSQLDatabaseType());
+ refreshTableWithRule(new PostgreSQLAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new SQLServerDatabaseType());
+ refreshTableWithRule(new SQLServerAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new SQL92DatabaseType());
+ refreshTableWithRule(new SQL92AlterTableStatement());
+ }
+
+ private void refreshTableWithRule(final AlterTableStatement alterTableStatement) throws SQLException {
+ alterTableStatement.setTable(new SimpleTableSegment(new TableNameSegment(1, 3, new IdentifierValue("t_order"))));
+ Map<String, DataSource> dataSourceMap = mock(HashMap.class);
+ TableContainedRule rule = mock(TableContainedRule.class);
+ Collection<ShardingSphereRule> rules = Collections.singletonList(rule);
+ when(materials.getRules()).thenReturn(rules);
+ when(rule.getTables()).thenReturn(Collections.singletonList("t_order"));
+ when(materials.getDataSourceMap()).thenReturn(dataSourceMap);
+ DataSource dataSource = mock(DataSource.class);
+ when(dataSourceMap.get(eq("ds"))).thenReturn(dataSource);
+ Connection connection = mock(Connection.class);
+ when(dataSource.getConnection()).thenReturn(connection);
+ DatabaseMetaData metaData = mock(DatabaseMetaData.class);
+ when(connection.getMetaData()).thenReturn(metaData);
+ ResultSet resultSet = mock(ResultSet.class);
+ when(metaData.getTables(any(), any(), any(), any())).thenReturn(resultSet);
+ when(resultSet.next()).thenReturn(false);
+ FederateRefresher<AlterTableStatement> federateRefresher = new AlterTableStatementFederateRefresher();
+ FederateSchemaMetadata schema = buildSchema();
+ federateRefresher.refresh(schema, Collections.singletonList("ds"), alterTableStatement, materials);
+ assertTrue(schema.getTables().containsKey("t_order"));
+ }
+
+ @Test
+ public void refreshTableWithoutRule() throws SQLException {
+ when(materials.getDatabaseType()).thenReturn(new MySQLDatabaseType());
+ refreshTableWithoutRule(new MySQLAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new OracleDatabaseType());
+ refreshTableWithoutRule(new OracleAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new PostgreSQLDatabaseType());
+ refreshTableWithoutRule(new PostgreSQLAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new SQLServerDatabaseType());
+ refreshTableWithoutRule(new SQLServerAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new SQL92DatabaseType());
+ refreshTableWithoutRule(new SQL92AlterTableStatement());
+ }
+
+ private void refreshTableWithoutRule(final AlterTableStatement alterTableStatement) throws SQLException {
+ alterTableStatement.setTable(
+ new SimpleTableSegment(new TableNameSegment(1, 3, new IdentifierValue("t_order"))));
+ Map<String, DataSource> dataSourceMap = mock(HashMap.class);
+ when(materials.getDataSourceMap()).thenReturn(dataSourceMap);
+ DataSource dataSource = mock(DataSource.class);
+ when(dataSourceMap.get(eq("ds"))).thenReturn(dataSource);
+ Connection connection = mock(Connection.class);
+ when(dataSource.getConnection()).thenReturn(connection);
+ DatabaseMetaData metaData = mock(DatabaseMetaData.class);
+ when(connection.getMetaData()).thenReturn(metaData);
+ ResultSet resultSet = mock(ResultSet.class);
+ when(metaData.getTables(any(), any(), any(), any())).thenReturn(resultSet);
+ when(resultSet.next()).thenReturn(false);
+ FederateRefresher<AlterTableStatement> federateRefresher = new AlterTableStatementFederateRefresher();
+ FederateSchemaMetadata schema = buildSchema();
+ federateRefresher.refresh(schema, Collections.singletonList("ds"), alterTableStatement, materials);
+ assertTrue(schema.getTables().containsKey("t_order"));
+ }
+
+ @Test
+ public void renameTableWithRule() throws SQLException {
+ when(materials.getDatabaseType()).thenReturn(new MySQLDatabaseType());
+ renameTableWithRule(new MySQLAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new OracleDatabaseType());
+ renameTableWithRule(new OracleAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new PostgreSQLDatabaseType());
+ renameTableWithRule(new PostgreSQLAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new SQLServerDatabaseType());
+ renameTableWithRule(new SQLServerAlterTableStatement());
+
+ when(materials.getDatabaseType()).thenReturn(new SQL92DatabaseType());
+ renameTableWithRule(new SQL92AlterTableStatement());
+ }
+
+ private void renameTableWithRule(final AlterTableStatement alterTableStatement) throws SQLException {
+ alterTableStatement.setTable(new SimpleTableSegment(new TableNameSegment(1, 3, new IdentifierValue("t_order"))));
+ alterTableStatement.setRenameTable(new SimpleTableSegment(new TableNameSegment(1, 3, new IdentifierValue("t_order_new"))));
+ Map<String, DataSource> dataSourceMap = mock(HashMap.class);
+ TableContainedRule rule = mock(TableContainedRule.class);
+ Collection<ShardingSphereRule> rules = Collections.singletonList(rule);
+ when(materials.getRules()).thenReturn(rules);
+ when(rule.getTables()).thenReturn(Arrays.asList("t_order", "t_order_new"));
+ when(materials.getDataSourceMap()).thenReturn(dataSourceMap);
+ DataSource dataSource = mock(DataSource.class);
+ when(dataSourceMap.get(eq("ds"))).thenReturn(dataSource);
+ Connection connection = mock(Connection.class);
+ when(dataSource.getConnection()).thenReturn(connection);
+ DatabaseMetaData metaData = mock(DatabaseMetaData.class);
+ when(connection.getMetaData()).thenReturn(metaData);
+ ResultSet resultSet = mock(ResultSet.class);
+ when(metaData.getTables(any(), any(), any(), any())).thenReturn(resultSet);
+ when(resultSet.next()).thenReturn(false);
+ FederateRefresher<AlterTableStatement> federateRefresher = new AlterTableStatementFederateRefresher();
+ FederateSchemaMetadata schema = buildSchema();
+ federateRefresher.refresh(schema, Collections.singletonList("ds"), alterTableStatement, materials);
+ assertFalse(schema.getTables().containsKey("t_order"));
+ assertTrue(schema.getTables().containsKey("t_order_new"));
+ }
+
+ @Test
+ public void renameTableWithoutRule() throws SQLException {
+ when(materials.getDatabaseType()).thenReturn(new MySQLDatabaseType());
+ renameTableWithoutRule(new MySQLAlterTableStatement());
+
Review comment:
Hi, this one is partly duplicated with #10715? Plus, could you look at comments on #10715?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org