You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "rbaddam (via GitHub)" <gi...@apache.org> on 2026/02/03 00:58:40 UTC
[PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
rbaddam opened a new pull request, #21393:
URL: https://github.com/apache/kafka/pull/21393
Fixed typos in comments across multiple Java classes to stay consistent and high quality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21393:
URL: https://github.com/apache/kafka/pull/21393#issuecomment-5739064347
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #21393:
URL: https://github.com/apache/kafka/pull/21393#discussion_r3155599107
##########
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##########
@@ -519,7 +519,7 @@ public Map<String, Object> parse(Map<?, ?> props) {
List<String> undefinedConfigKeys = undefinedDependentConfigs();
if (!undefinedConfigKeys.isEmpty()) {
String joined = undefinedConfigKeys.stream().map(String::toString).collect(Collectors.joining(","));
- throw new ConfigException("Some configurations in are referred in the dependents, but not defined: " + joined);
+ throw new ConfigException("Some configurations are referred in the dependents but not defined: " + joined);
Review Comment:
nit: This would be better worded as `"Some configurations are referred to in the dependents but not defined: "`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #21393: MINOR: Fixed typos in comments across multiple Java classes
URL: https://github.com/apache/kafka/pull/21393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
Posted by "rbaddam (via GitHub)" <gi...@apache.org>.
rbaddam commented on PR #21393:
URL: https://github.com/apache/kafka/pull/21393#issuecomment-3843847654
@DL1231 / @Tim-Brooks / @m1a2st: Could you please review and approve this change, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #21393:
URL: https://github.com/apache/kafka/pull/21393#issuecomment-4659885168
@rbaddam There's an outstanding comment to address on this PR. Then it's ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
Posted by "rbaddam (via GitHub)" <gi...@apache.org>.
rbaddam commented on PR #21393:
URL: https://github.com/apache/kafka/pull/21393#issuecomment-3862985030
@m1a2st could you please merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fixed typos in comments across multiple Java classes [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21393:
URL: https://github.com/apache/kafka/pull/21393#issuecomment-6259194782
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org