You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Akanksha-kedia (via GitHub)" <gi...@apache.org> on 2026/07/22 11:06:35 UTC

[PR] Rebuild HNSW vector index when dimension or distance function changes [pinot]

Akanksha-kedia opened a new pull request, #19046:
URL: https://github.com/apache/pinot/pull/19046

   ## Description
   
   Extends `VectorIndexHandler` to detect and rebuild a HNSW vector index when the vector dimension or distance function changes in the table config — mirroring the same pattern used for bloom filter (#18898) and JSON index (#18920) rebuilds.
   
   ### Problem
   Previously, if a table's vector index config changed (e.g. dimension or distance function), the existing index would be silently reused without rebuilding:
   - A changed **dimension** produces a structurally incompatible index that will fail or return garbage results.
   - A changed **distance function** silently returns wrong query results (wrong similarity metric applied).
   
   Neither failure was detectable without the stored build-time config.
   
   ### Solution
   Write a lightweight metadata file (`.vector.hnsw.metadata`) alongside the HNSW Lucene index directory at `seal()` time, recording:
   - `vectorDimension` (int)
   - `vectorSimilarityFunction` (Lucene `VectorSimilarityFunction` name)
   
   `VectorIndexHandler.needUpdateIndices()` reads this file and triggers a rebuild when either field differs from the current table config.
   
   **Backward compatibility:** Legacy segments without a metadata file skip the check and receive the file on their next rebuild — no forced migration.
   
   ### Files changed
   - `HnswVectorIndexCreator` – writes `.vector.hnsw.metadata` at seal time
   - `VectorIndexHandler` – reads metadata file and triggers rebuild on mismatch
   - `VectorIndexUtils` – helper for reading/writing the metadata file
   - `V1Constants` – adds `VECTOR_HNSW_METADATA_FILE_EXTENSION` constant
   - `VectorIndexHandlerTest` – unit tests for all rebuild/skip branches
   
   ## Test plan
   - [ ] New `VectorIndexHandlerTest` covers: dimension change → rebuild, distance-function change → rebuild, no change → skip, missing metadata → skip (backward compat), metadata present + matching → skip
   - [ ] Existing vector index integration tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Rebuild HNSW vector index when dimension or distance function changes [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19046:
URL: https://github.com/apache/pinot/pull/19046#issuecomment-5239104855

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19046?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.25000%` with `33 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.35%. Comparing base ([`3ffb614`](https://app.codecov.io/gh/apache/pinot/commit/3ffb61485b8e9fd5dc1fe85dfcfed1a2f500b2f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4c0e55f`](https://app.codecov.io/gh/apache/pinot/commit/4c0e55f9880be6e3db1cb53e1a81fb2ecea9e7d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/19046?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...index/loader/invertedindex/VectorIndexHandler.java](https://app.codecov.io/gh/apache/pinot/pull/19046?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Fsegment%2Findex%2Floader%2Finvertedindex%2FVectorIndexHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2luZGV4L2xvYWRlci9pbnZlcnRlZGluZGV4L1ZlY3RvckluZGV4SGFuZGxlci5qYXZh) | 14.28% | [21 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../segment/local/segment/store/VectorIndexUtils.java](https://app.codecov.io/gh/apache/pinot/pull/19046?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Fsegment%2Fstore%2FVectorIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L3N0b3JlL1ZlY3RvckluZGV4VXRpbHMuamF2YQ==) | 50.00% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (3ffb614) and HEAD (4c0e55f). Click for more details.
   > 
   > <details><summary>HEAD has 4 uploads less than BASE</summary>
   >
   >| Flag | BASE (3ffb614) | HEAD (4c0e55f) |
   >|------|------|------|
   >|java-25|6|5|
   >|temurin|6|5|
   >|unittests|2|1|
   >|unittests2|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19046      +/-   ##
   ============================================
   - Coverage     66.63%   57.35%   -9.28%     
   + Complexity     1423        7    -1416     
   ============================================
     Files          3443     2658     -785     
     Lines        218663   159153   -59510     
     Branches      34801    26148    -8653     
   ============================================
   - Hits         145705    91283   -54422     
   + Misses        61230    60059    -1171     
   + Partials      11728     7811    -3917     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
   | [java-25](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.35% <31.25%> (-9.28%)` | :arrow_down: |
   | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
   | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.35% <31.25%> (-9.28%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.35% <31.25%> (-9.28%)` | :arrow_down: |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.35% <31.25%> (+0.05%)` | :arrow_up: |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19046?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Rebuild HNSW vector index when dimension or distance function changes [pinot]

Posted by "J-HowHuang (via GitHub)" <gi...@apache.org>.
J-HowHuang commented on code in PR #19046:
URL: https://github.com/apache/pinot/pull/19046#discussion_r3669366725


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/VectorIndexUtils.java:
##########
@@ -43,9 +46,52 @@
 
 
 public class VectorIndexUtils {
+  private static final String METADATA_KEY_DIMENSION = "dimension";
+  private static final String METADATA_KEY_DISTANCE_FUNCTION = "distanceFunction";
+
   private VectorIndexUtils() {
   }
 
+  /**
+   * Writes a lightweight metadata file next to the HNSW index directory, recording the vector dimension and
+   * similarity function. This file is used by
+   * {@link org.apache.pinot.segment.local.segment.index.loader.invertedindex.VectorIndexHandler}
+   * to detect config changes and trigger an index rebuild when necessary.
+   *
+   * <p>Legacy segments built before this method existed have no metadata file; the handler skips config-change
+   * detection for those segments (treating the absence of the file as "unknown, assume unchanged").
+   */
+  public static void writeVectorIndexMetadata(File segmentIndexDir, String column, int dimension,

Review Comment:
   Same here. This helper class isn't for HNSW implementation only, so this method shouldn't only serve HNSW



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/VectorIndexHandler.java:
##########
@@ -545,6 +551,58 @@ && hasCombinedFile(indexDir, column, desiredBackend)) {
     }
   }
 
+  /**
+   * Checks whether the HNSW vector index config has changed by comparing the metadata file written at index-creation

Review Comment:
   This only applies to HNSW vector index, however we share the same `VectorIndexHandler` for all vector index implementations.
   
   Please consider making this extendable to all other implementations, it shouldn't only serve one specific HNSW implementation.



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/VectorIndexUtils.java:
##########
@@ -43,9 +46,52 @@
 
 
 public class VectorIndexUtils {
+  private static final String METADATA_KEY_DIMENSION = "dimension";
+  private static final String METADATA_KEY_DISTANCE_FUNCTION = "distanceFunction";
+
   private VectorIndexUtils() {
   }
 
+  /**
+   * Writes a lightweight metadata file next to the HNSW index directory, recording the vector dimension and
+   * similarity function. This file is used by
+   * {@link org.apache.pinot.segment.local.segment.index.loader.invertedindex.VectorIndexHandler}
+   * to detect config changes and trigger an index rebuild when necessary.
+   *
+   * <p>Legacy segments built before this method existed have no metadata file; the handler skips config-change
+   * detection for those segments (treating the absence of the file as "unknown, assume unchanged").
+   */
+  public static void writeVectorIndexMetadata(File segmentIndexDir, String column, int dimension,
+      VectorSimilarityFunction similarityFunction)
+      throws IOException {
+    File metadataFile = new File(segmentIndexDir, column + Indexes.VECTOR_HNSW_INDEX_METADATA_FILE_EXTENSION);
+    Properties props = new Properties();
+    props.setProperty(METADATA_KEY_DIMENSION, String.valueOf(dimension));
+    props.setProperty(METADATA_KEY_DISTANCE_FUNCTION, similarityFunction.name());
+    try (FileOutputStream out = new FileOutputStream(metadataFile)) {
+      props.store(out, null);
+    }
+  }
+
+  /**
+   * Reads the HNSW vector index metadata file for the given column. Returns {@code null} if the file does not
+   * exist (legacy segment) or cannot be parsed.
+   */
+  @Nullable
+  public static Properties readVectorIndexMetadata(File segmentIndexDir, String column) {

Review Comment:
   Same here. This helper class isn't for HNSW implementation only, so this method shouldn't only serve HNSW



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Rebuild HNSW vector index when dimension or distance function changes [pinot]

Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #19046:
URL: https://github.com/apache/pinot/pull/19046#issuecomment-5045086851

   cc @Jackie-Jiang @richardstartin @npawar — would appreciate a review when you get a chance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Rebuild HNSW vector index when dimension or distance function changes [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #19046:
URL: https://github.com/apache/pinot/pull/19046#issuecomment-5109657545

   @J-HowHuang Could you help review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Rebuild HNSW vector index when dimension or distance function changes [pinot]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #19046:
URL: https://github.com/apache/pinot/pull/19046#discussion_r3669215963


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/VectorIndexHandler.java:
##########
@@ -545,6 +551,58 @@ && hasCombinedFile(indexDir, column, desiredBackend)) {
     }
   }
 
+  /**
+   * Checks whether the HNSW vector index config has changed by comparing the metadata file written at index-creation
+   * time with the current {@link VectorIndexConfig}.
+   *
+   * <p>The metadata file (written by {@code HnswVectorIndexCreator}) records the vector dimension and
+   * {@link VectorSimilarityFunction} used to build the index. Changing either field
+   * produces a structurally incompatible index (wrong vector size) or silently wrong query results (wrong distance
+   * metric), so a rebuild is required.
+   *
+   * <p>Legacy segments built before this metadata was introduced have no metadata file; config-change detection is
+   * skipped for those segments (the file will be created the next time the index is rebuilt for any reason).
+   */
+  private boolean isVectorConfigChanged(File indexDir, String column, VectorIndexConfig desiredConfig,
+      String segmentName) {
+    File segmentDirectory = SegmentDirectoryPaths.segmentDirectoryFor(indexDir,
+        _segmentDirectory.getSegmentMetadata().getVersion());
+    Properties metadata = VectorIndexUtils.readVectorIndexMetadata(segmentDirectory, column);
+    if (metadata == null) {
+      // No metadata file — legacy segment; skip config-change detection.
+      return false;
+    }
+    try {
+      int storedDimension = Integer.parseInt(metadata.getProperty("dimension"));
+      int desiredDimension = desiredConfig.getVectorDimension();
+      if (storedDimension != desiredDimension) {
+        LOGGER.info("Vector index config changed for segment: {}, column: {} "
+                + "(dimension: {} → {}). Index needs to be rebuilt.",
+            segmentName, column, storedDimension, desiredDimension);
+        return true;
+      }
+
+      VectorSimilarityFunction storedFunc =
+          VectorSimilarityFunction.valueOf(metadata.getProperty("distanceFunction"));
+      VectorIndexConfig.VectorDistanceFunction desiredDistanceFunc = desiredConfig.getVectorDistanceFunction();
+      // Null distanceFunction defaults to COSINE (see VectorIndexConfig.DEFAULT_VECTOR_DISTANCE_FUNCTION).
+      if (desiredDistanceFunc == null) {
+        desiredDistanceFunc = VectorIndexConfig.VectorDistanceFunction.COSINE;
+      }
+      VectorSimilarityFunction desiredFunc = VectorIndexUtils.toSimilarityFunction(desiredDistanceFunc);
+      if (storedFunc != desiredFunc) {
+        LOGGER.info("Vector index config changed for segment: {}, column: {} "
+                + "(distanceFunction: {} → {}). Index needs to be rebuilt.",
+            segmentName, column, storedFunc, desiredFunc);
+        return true;
+      }
+    } catch (Exception e) {
+      LOGGER.warn("Failed to parse vector index metadata for segment: {}, column: {}; skipping config-change check",
+          segmentName, column, e);
+    }

Review Comment:
   If the metadata file exists but is unreadable/corrupt or missing expected keys, the current behavior is to log a warning and then *skip* the config-change check (returning false). That can leave an incompatible index in place and produce wrong results when dimension/distance changes. Safer behavior is to treat parse failure as requiring a rebuild (the rebuild will also rewrite a clean metadata file).



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/vector/HnswVectorIndexCreator.java:
##########
@@ -110,6 +110,8 @@ public void seal() {
     try {
       LOGGER.info("Sealing HNSW index for column: {}", _vectorColumn);
       _indexWriter.forceMerge(1);
+      VectorIndexUtils.writeVectorIndexMetadata(_segmentIndexDir, _vectorColumn, _vectorDimension,
+          _vectorSimilarityFunction);

Review Comment:
   The metadata file is written to the current (V1/V2) segment build directory, but offline segment generation is documented here as always V1 and then converted to V3. The V1/V2→V3 converter copies the Lucene HNSW directory but does not copy sibling files like `*.vector.hnsw.metadata`, and then deletes all files in the V1/V2 directory — so the metadata will be dropped for V3 segments and config-drift detection will be silently skipped.



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/VectorIndexHandler.java:
##########
@@ -496,7 +501,8 @@ public void updateIndices(SegmentDirectory.Writer segmentWriter)
       VectorBackendType desiredBackend = desiredConfig.resolveBackendType();
       VectorBackendType existingBackend = VectorIndexUtils.detectVectorIndexBackend(indexDir, column);
       // Storage-format comparison — see the twin check in needUpdateIndices.
-      if (existingBackend != null && existingBackend != VectorIndexUtils.storageFormatOf(desiredBackend)) {
+      if ((existingBackend != null && existingBackend != VectorIndexUtils.storageFormatOf(desiredBackend))
+          || isVectorConfigChanged(indexDir, column, desiredConfig, segmentName)) {
         LOGGER.info("Rebuilding Vector index for segment: {}, column: {} (backend changed from {} to {})",
             segmentName, column, existingBackend, desiredBackend);

Review Comment:
   This log line says the backend changed, but the rebuild can also be triggered by `isVectorConfigChanged(...)` (dimension/distance change) even when the backend stays the same. The current message can be misleading during ops/debugging (e.g., logs show "backend changed from HNSW to HNSW").



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Rebuild HNSW vector index when dimension or distance function changes [pinot]

Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #19046:
URL: https://github.com/apache/pinot/pull/19046#issuecomment-5236295662

   Hi @J-HowHuang — noting the consistency concern raised in apache/pinot#18920 here as well, since this PR is one of the three cited.
   
   The vector index currently persists its config as an individual metadata file. To address the uniform-solution request, `loadMetadataProperties()`, `readStoredIndexConfig()`, and `setStoredIndexConfig()` have been added to `BaseIndexHandler` (landed in apache/pinot#18920) as protected generic utilities backed by the existing `metadata.properties` file. Any handler can now call them with a stable key suffix (e.g. `"vectorIndexConfig"`) to persist and compare any `IndexConfig` subclass without duplicating the serialization boilerplate.
   
   Happy to migrate this PR to use that pattern in a follow-up if you'd prefer a consistent approach across all three PRs. Alternatively, if the individual-file approach is preferred here (e.g. for size or isolation reasons), let me know and we can document the rationale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org