You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2011/04/26 21:51:03 UTC
[jira] [Created] (HIVE-2134) Remove System.exit
Remove System.exit
-------------------
Key: HIVE-2134
URL: https://issues.apache.org/jira/browse/HIVE-2134
Project: Hive
Issue Type: Improvement
Reporter: Ashutosh Chauhan
Fix For: 0.8.0
Attachments: no_sysexit.patch
System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2134) Remove System.exit
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026879#comment-13026879 ]
Amareshwari Sriramadasu commented on HIVE-2134:
-----------------------------------------------
Patch removes System.exit calls and as logs warning saying it is exiting. Shouldn't it throw out the exceptions for exit?
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2134:
-----------------------------------
Status: Patch Available (was: Open)
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2134:
-----------------------------
Status: Open (was: Patch Available)
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2134) Remove System.exit
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031856#comment-13031856 ]
Ashutosh Chauhan commented on HIVE-2134:
----------------------------------------
$ svn co http://svn.apache.org/repos/asf/hive/trunk .
$ curl https://issues.apache.org/jira/secure/attachment/12477856/hive_2134.patch | patch -p0
$ ant package
BUILD SUCCESSFUL
Total time: 2 minutes 35 seconds
works for me. can you double check if you have clean upto date tree.
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2134) Remove System.exit
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031541#comment-13031541 ]
Amareshwari Sriramadasu commented on HIVE-2134:
-----------------------------------------------
Looks fine. Will commit if tests pass.
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2134) Remove System.exit
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032251#comment-13032251 ]
Amareshwari Sriramadasu commented on HIVE-2134:
-----------------------------------------------
Ashutosh, ant package builds properly. But ant test fails with compilation error.
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2134:
-----------------------------------
Assignee: Ashutosh Chauhan
Status: Patch Available (was: Open)
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HIVE-2134:
------------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
Thanks Ashutosh!
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, hive_2134_1.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2134:
-----------------------------------
Status: Patch Available (was: Open)
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, hive_2134_1.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2134:
-----------------------------------
Attachment: hive_2134.patch
Now throws the exception instead of doing System.exit. Didn't do it in MetaStoreUtils since there it is launched in a thread and run() doesn't allow to throw checked exceptions. I could have casted exception into RuntimeException but even that would not make sense because once exception is thrown in thread, there is no one who can catch it and do something with it.
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2134:
-----------------------------------
Attachment: no_sysexit.patch
As discussed in April Contributor meeting its good to get rid of System.exit. This patch removes all System.exit from Metastore directory.
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HIVE-2134:
------------------------------------------
Status: Open (was: Patch Available)
Seems patch has gone stale. I'm compilation error with the patch:
TestMetaStoreEventListener.java:56: unreported exception java.lang.Throwable;
must be caught or declared to be thrown
[javac] HiveMetaStore.main(new String[]{msPort});
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2134) Remove System.exit
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2134:
-----------------------------------
Attachment: hive_2134_1.patch
Sorry about that. Uploaded new patch with no compilation errors.
> Remove System.exit
> -------------------
>
> Key: HIVE-2134
> URL: https://issues.apache.org/jira/browse/HIVE-2134
> Project: Hive
> Issue Type: Improvement
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive_2134.patch, hive_2134_1.patch, no_sysexit.patch
>
>
> System.exit exists in various places in code. Its good to get rid of it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira