You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/01 09:36:54 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #16019: [FLINK-22686][checkpointing] Incompatible subtask mappings while resuming from unaligned checkpoints
dawidwys commented on a change in pull request #16019:
URL: https://github.com/apache/flink/pull/16019#discussion_r642944396
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/TaskStateAssignment.java
##########
@@ -169,31 +170,37 @@ public OperatorSubtaskState getSubtaskState(OperatorInstanceID instanceID) {
instanceID,
inputOperatorID,
getUpstreamAssignments(),
- assignment ->
- assignment.outputSubtaskMappings.get(
- getAssignmentIndex(
- assignment.getDownstreamAssignments(),
- this)),
- assignment ->
- assignment.getOutputMapping(
- getAssignmentIndex(
- assignment.getDownstreamAssignments(),
- this)),
+ (assignment, recompute) -> {
Review comment:
Yes, I don't like that either, as you expose additional flag to a `public` method of the class. Moreover, it's not that different from the current version. It's just that we move some part of the lambda inside of the `getOutputMapping` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org