You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Xavier Detant (JIRA)" <ji...@apache.org> on 2012/06/10 15:54:42 UTC

[jira] [Updated] (EMAIL-118) smtpPort setter and getter doesn't works with the same type in EmailClass

     [ https://issues.apache.org/jira/browse/EMAIL-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Detant updated EMAIL-118:
--------------------------------

    Attachment: SmtpAsInt.patch

The patch to change smtp port from String to int.
                
> smtpPort setter and getter doesn't works with the same type in EmailClass
> -------------------------------------------------------------------------
>
>                 Key: EMAIL-118
>                 URL: https://issues.apache.org/jira/browse/EMAIL-118
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Xavier Detant
>            Priority: Trivial
>              Labels: patch
>         Attachments: SmtpAsInt.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The smtpPort in the Email class can be set as an int but is get as a String. This is quite bad design, the getter and the setter should works with the same type. As smtp ports is a number, the getter which is currently _public String getSmtpPort()_ should be _public int getSmtpPort()_:

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira