[GitHub] [incubator-superset] betodealmeida opened a new pull request #7255: Pass viz type to GET requests

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #7255: Pass viz type to GET requests
URL: https://github.com/apache/incubator-superset/pull/7255
 
 
   ##### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   We need to pass the visualization type to the initial `GET` request in the Explore view, since the payload is dependent on it.
   
   <!-- ##### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ##### TEST PLAN
   <!--- What steps were taken to verify -->
   
   We had a problem where:
   
   1. User would create a new chart in Explore, using table view.
   2. User would switch to a different visualization type.
   3. Client would run a `GET` based only on the slice id, returning the wrong payload type. In our case, the Mapbox API key was not sent.
   
   I changed the `GET` request to pass the visualization type. Another alternative might be to not use `GET` requests in the Explore view, at the cost of the initial load being slow. I'll monitor this during the first days of GA.
   
   ##### ADDITIONAL INFORMATION
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> 
   <!--- Check any relevant boxes with "x" -->
       [ ] Has associated issue:
       [ ] Changes UI
       [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
       [ ] Introduces new feature or API
       [ ] Removes existing feature or API
       [X] Fixes bug
       [ ] Refactors code
       [ ] Adds test(s)
   
   ##### REVIEWERS
   
   @xtinec 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org