You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/16 22:02:38 UTC

[GitHub] [incubator-mxnet] DickJC123 commented on pull request #19158: [1.x] Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123)

DickJC123 commented on pull request #19158:
URL: https://github.com/apache/incubator-mxnet/pull/19158#issuecomment-693688769


   I've pushed a fix to this set-vs-string_append, and changed a few minor details with the approach.  I'd be surprised if it fixes things since the referenced line is not in the build's code path (I think) due to:
   
   https://github.com/apache/incubator-mxnet/blob/38c9d57f9a14578be4fc739b9d6880b49b00c4fc/CMakeLists.txt#L76
   
   Is it possible to have the 1.x Windows build use the same MSVC compiler as master (which doesn't seem to have the problem with -compress-all or the link OOM error)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org