You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/17 16:41:37 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #38690: [SPARK-41177][PROTOBUF][TESTS] Fix maven test failed of `protobuf` module
LuciferYang commented on code in PR #38690:
URL: https://github.com/apache/spark/pull/38690#discussion_r1025435300
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufCatalystDataConversionSuite.scala:
##########
@@ -34,9 +34,10 @@ import org.apache.spark.unsafe.types.UTF8String
class ProtobufCatalystDataConversionSuite
extends SparkFunSuite
with SharedSparkSession
- with ExpressionEvalHelper {
+ with ExpressionEvalHelper
+ with ProtobufTestBase {
- private val testFileDesc = testFile("catalyst_types.desc").replace("file:/", "/")
+ private val testFileDesc = testFile("catalyst_types.desc", "protobuf/catalyst_types.desc")
Review Comment:
sbt need `catalyst_types.desc` but maven need `protobuf/catalyst_types.desc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org