[GitHub] [spark] cloud-fan commented on a change in pull request #34796: [SPARK-37533][SQL] New SQL function: try_element_at

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34796:
URL: https://github.com/apache/spark/pull/34796#discussion_r761946227



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -296,7 +296,7 @@ case class Elt(
       val index = indexObj.asInstanceOf[Int]
       if (index <= 0 || index > inputExprs.length) {
         if (failOnError) {
-          throw QueryExecutionErrors.invalidArrayIndexError(index, inputExprs.length)
+          throw QueryExecutionErrors.invalidStringIndexError(index, inputExprs.length)

Review comment:
       the name `StringIndex` is a bit misleading. how about `InputIndex`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org