You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2016/05/20 23:56:09 UTC
[Impala-CR](cdh5-trunk) Revert "Revert "Add Kudu test helpers""
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3160
Change subject: Revert "Revert "Add Kudu test helpers""
......................................................................
Revert "Revert "Add Kudu test helpers""
This reverts commit f8dd5413b65d30646c3745dfc738ed812d50a51f and
effectively re-adds commit 9248dcb70478b8f93f022893776a0960f45fdc28. The
difference between this patch and its original is that I fixed the
changes introduced in infra/python/bootstrap_virtualenv.py to be
python2.4-compatible:
- removed the use of str.format(), preferring a str.join() pattern
- removed the call of the exit() builtin to prefer sys.exit()
The only testing I did for this patch was to ensure
CDH Impala-packaging-on-demand works.
Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
---
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
A bin/impala-python-common.sh
M infra/python/bootstrap_virtualenv.py
A infra/python/deps/Cython-0.23.4.tar.gz
A infra/python/deps/kudu-python-0.1.1.tar.gz
A infra/python/deps/linecache2-1.0.0-py2.py3-none-any.whl
A infra/python/deps/numpy-1.10.4.tar.gz
M infra/python/deps/requirements.txt
A infra/python/deps/traceback2-1.4.0-py2.py3-none-any.whl
A infra/python/deps/unittest2-1.1.0-py2.py3-none-any.whl
M tests/common/__init__.py
M tests/conftest.py
14 files changed, 350 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/60/3160/2
--
To view, visit http://gerrit.cloudera.org:8080/3160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-CR](cdh5-trunk) Revert "Revert "Add Kudu test helpers""
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Internal Jenkins, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3160
to look at the new patch set (#3).
Change subject: Revert "Revert "Add Kudu test helpers""
......................................................................
Revert "Revert "Add Kudu test helpers""
This reverts commit f8dd5413b65d30646c3745dfc738ed812d50a51f and
effectively re-adds commit 9248dcb70478b8f93f022893776a0960f45fdc28. The
difference between this patch and its original is that I fixed the
changes introduced in infra/python/bootstrap_virtualenv.py to be
python2.4-compatible:
- removed the use of str.format(), preferring a str.join() pattern
- removed the call of the exit() builtin to prefer sys.exit()
The only testing I did for this patch was to ensure
CDH Impala-packaging-on-demand works.
Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
---
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
A bin/impala-python-common.sh
M infra/python/bootstrap_virtualenv.py
A infra/python/deps/Cython-0.23.4.tar.gz
A infra/python/deps/kudu-python-0.1.1.tar.gz
A infra/python/deps/linecache2-1.0.0-py2.py3-none-any.whl
A infra/python/deps/numpy-1.10.4.tar.gz
M infra/python/deps/requirements.txt
A infra/python/deps/traceback2-1.4.0-py2.py3-none-any.whl
A infra/python/deps/unittest2-1.1.0-py2.py3-none-any.whl
M tests/common/__init__.py
M tests/conftest.py
14 files changed, 350 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/60/3160/3
--
To view, visit http://gerrit.cloudera.org:8080/3160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-CR](cdh5-trunk) Revert "Revert "Add Kudu test helpers""
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: Revert "Revert "Add Kudu test helpers""
......................................................................
Revert "Revert "Add Kudu test helpers""
This reverts commit f8dd5413b65d30646c3745dfc738ed812d50a51f and
effectively re-adds commit 9248dcb70478b8f93f022893776a0960f45fdc28. The
difference between this patch and its original is that I fixed the
changes introduced in infra/python/bootstrap_virtualenv.py to be
python2.4-compatible:
- removed the use of str.format(), preferring a str.join() pattern
- removed the call of the exit() builtin to prefer sys.exit()
The only testing I did for this patch was to ensure
CDH Impala-packaging-on-demand works.
Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
Reviewed-on: http://gerrit.cloudera.org:8080/3160
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Internal Jenkins
---
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
A bin/impala-python-common.sh
M infra/python/bootstrap_virtualenv.py
A infra/python/deps/Cython-0.23.4.tar.gz
A infra/python/deps/kudu-python-0.1.1.tar.gz
A infra/python/deps/linecache2-1.0.0-py2.py3-none-any.whl
A infra/python/deps/numpy-1.10.4.tar.gz
M infra/python/deps/requirements.txt
A infra/python/deps/traceback2-1.4.0-py2.py3-none-any.whl
A infra/python/deps/unittest2-1.1.0-py2.py3-none-any.whl
M tests/common/__init__.py
M tests/conftest.py
14 files changed, 350 insertions(+), 44 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-CR](cdh5-trunk) Revert "Revert "Add Kudu test helpers""
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Revert "Revert "Add Kudu test helpers""
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Revert "Revert "Add Kudu test helpers""
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: Revert "Revert "Add Kudu test helpers""
......................................................................
Patch Set 3: Code-Review+2
rebase; carry +2
--
To view, visit http://gerrit.cloudera.org:8080/3160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02ed97473868eacf45b25abe89b41e6fa2fce325
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No