You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/18 06:09:17 UTC
[GitHub] [incubator-doris] luozenglin opened a new pull request #6263: [Monitor] Support the collection and storage of monitoring data.
luozenglin opened a new pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263
Collect the metrics of each node and store it in bdbje on FE. Then we can get the monitoring data through the http server.
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6262) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] luozenglin commented on a change in pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
luozenglin commented on a change in pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263#discussion_r674496478
##########
File path: fe/fe-core/src/test/java/org/apache/doris/metric/collector/MonitorTest.java
##########
@@ -0,0 +1,210 @@
+package org.apache.doris.metric.collector;
Review comment:
done. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263#issuecomment-882076014
why not use prometheus to collect monitor data? what's the motivation or benefit to store monitor data in bdbje?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263#issuecomment-882074319
Please add the performance test of bdbje when saving metric data, and the estimate of data volume that will be stored in bdbje.
And further more, the cleaning and aggregation of historical data has not been solved yet, you can record a TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] luozenglin commented on pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
luozenglin commented on pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263#issuecomment-884652894
> Please add the performance test of bdbje when saving metric data, and the estimate of data volume that will be stored in bdbje.
> And further more, the cleaning and aggregation of historical data has not been solved yet, you can record a TODO
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263#discussion_r671858733
##########
File path: fe/fe-core/src/test/java/org/apache/doris/metric/collector/MonitorTest.java
##########
@@ -0,0 +1,210 @@
+package org.apache.doris.metric.collector;
Review comment:
License header missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263#issuecomment-913359619
abondoned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6263: [Monitor] Support the collection and storage of monitoring data.
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6263:
URL: https://github.com/apache/incubator-doris/pull/6263#issuecomment-882077345
> why not use prometheus to collect monitor data? what's the motivation or benefit to store monitor data in bdbje?
Many users did not deploy a monitoring system in the early stage of using Doris, which makes it difficult to troubleshoot some problems. So this function stores a small number of key metrics in a built-in way to help troubleshoot problems.
This is not a substitute feature for the standard monitoring system, but in some cases it helps to locate the problem as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org