You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/09/15 10:41:31 UTC

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3342: [SCB-2683] Modifying Invalid Fields in the Data Reported by the Dashb…

liubao68 commented on code in PR #3342:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3342#discussion_r971825904


##########
foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/api/registry/MicroserviceInstance.java:
##########
@@ -193,8 +179,6 @@ public static MicroserviceInstance createFromDefinition(Configuration configurat
     MicroserviceInstance microserviceInstance = new MicroserviceInstance();
     // default hard coded values
     microserviceInstance.setStage(DefinitionConst.DEFAULT_STAGE);
-    microserviceInstance
-        .setEnvironment(BootStrapProperties.readServiceInstanceEnvironment(configuration));

Review Comment:
   delete `BootStrapProperties.readServiceInstanceEnvironment` too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org