You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2025/08/25 16:29:42 UTC

(superset) branch master updated: fix(theming): explore chart type style fixes, nav right menu spacing fixed (#34795)

This is an automated email from the ASF dual-hosted git repository.

jli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new b381992a75 fix(theming): explore chart type style fixes, nav right menu spacing fixed (#34795)
b381992a75 is described below

commit b381992a752afd1ee6688d3cac059d6157b2be63
Author: Rafael Benitez <re...@gmail.com>
AuthorDate: Mon Aug 25 12:29:35 2025 -0400

    fix(theming): explore chart type style fixes, nav right menu spacing fixed (#34795)
---
 .../explore/components/controls/VizTypeControl/VizTile.tsx |  2 +-
 .../components/controls/VizTypeControl/constants.tsx       | 14 ++++++++++++--
 superset-frontend/src/features/home/RightMenu.tsx          |  5 ++++-
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx
index e1f73ce5fc..b1d0de5f6b 100644
--- a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx
+++ b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx
@@ -111,7 +111,7 @@ export const VizTile = ({
           ${isActive &&
           css`
             width: 100%;
-            background-color: ${theme.colorBgContainer};
+            background-color: ${theme.colorBgLayout};
             transition:
               width ${TILE_TRANSITION_TIME} ease-out,
               background-color ${TILE_TRANSITION_TIME} ease-out;
diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/constants.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/constants.tsx
index dbea04c27a..75907090e3 100644
--- a/superset-frontend/src/explore/components/controls/VizTypeControl/constants.tsx
+++ b/superset-frontend/src/explore/components/controls/VizTypeControl/constants.tsx
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { VizType } from '@superset-ui/core';
+import { VizType, css } from '@superset-ui/core';
 import { Icons } from '@superset-ui/core/components/Icons';
 import { VizMeta } from './types';
 
@@ -33,7 +33,17 @@ export const FEATURED_CHARTS: VizMeta[] = [
   { name: VizType.Table, icon: <Icons.TableOutlined iconSize="l" /> },
   {
     name: VizType.BigNumberTotal,
-    icon: <Icons.BigNumberChartTile iconSize="l" viewBox="0 0 16 14" />,
+    icon: (
+      <Icons.BigNumberChartTile
+        iconSize="l"
+        viewBox="0 0 16 14"
+        css={css`
+          path {
+            fill: currentColor;
+          }
+        `}
+      />
+    ),
   },
   { name: VizType.Pie, icon: <Icons.PieChartOutlined iconSize="l" /> },
 ];
diff --git a/superset-frontend/src/features/home/RightMenu.tsx b/superset-frontend/src/features/home/RightMenu.tsx
index d888467c72..3af7172d9a 100644
--- a/superset-frontend/src/features/home/RightMenu.tsx
+++ b/superset-frontend/src/features/home/RightMenu.tsx
@@ -684,12 +684,15 @@ const RightMenu = ({
           align-items: center;
 
           .submenu-with-caret {
-            padding: 0 ${theme.paddingSM}px;
+            padding: 0 ${theme.sizeUnit}px;
             .ant-menu-submenu-title {
               display: flex;
               gap: ${theme.sizeUnit * 2}px;
               flex-direction: row-reverse;
             }
+            &.ant-menu-submenu::after {
+              inset-inline: ${theme.sizeUnit}px;
+            }
           }
         `}
         selectable={false}