[GitHub] andrzej-kaczmarek commented on a change in pull request #206: Add support for Eddystone TLM Plain

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #206: Add support for Eddystone TLM Plain
URL: https://github.com/apache/mynewt-nimble/pull/206#discussion_r223476340
 
 

 ##########
 File path: nimble/host/include/host/ble_eddystone.h
 ##########
 @@ -106,6 +106,29 @@ int ble_eddystone_set_adv_data_url(struct ble_hs_adv_fields *adv_fields,
                                    uint8_t url_body_len, uint8_t suffix,
                                    int8_t measured_power);
 
+/**
+ * Configures the device to advertise Eddystone TLM (Unencrypted) beacons.
+ *
+ * @param adv_fields            The base advertisement fields to transform into
+ *                                  an eddystone beacon.  All configured fields
+ *                                  are preserved; you probably want to clear
+ *                                  this struct before calling this function.
+ * @param battery_voltage       The 2-byte battery voltage in mV to advertise.
+ * @param temperature           The 2-byte temperature to advertise.
+ * @param adv_pdu_count         The 4-byte total packet count to advertise.
+ * @param time_since_power_up   The 4-byte count in 0.1 Seconds since the device 
+ *                                  started / rebooted.
+ *
+ * @return                      0 on success;
+ *                              BLE_HS_EBUSY if advertising is in progress;
 
 Review comment:
   I don't think this will ever return `BLE_HS_EBUSY` since it's perfectly fine to change advertising data while advertising is in progress

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services