You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2015/04/23 08:51:22 UTC
[GitHub] spark pull request: [SPARK-7069][SQL] Rename NativeType -> AtomicT...
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/5650
[SPARK-7069][SQL] Rename NativeType -> AtomicType
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark atomic-type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5650.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5650
----
commit 01b673d17048b0727a83ca3f86be327a2a6e1365
Author: Reynold Xin <rx...@databricks.com>
Date: 2015-04-23T05:07:58Z
[SPARK-7068][SQL] Remove PrimitiveType
commit 97d2e1d86f6cb73269a5a11b7d8ce8b6808a3d89
Author: Reynold Xin <rx...@databricks.com>
Date: 2015-04-23T06:50:21Z
[SPARK-7069][SQL] Rename NativeType -> AtomicType.
Also renamed JvmType to InternalType.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7069][SQL] Rename NativeType -> AtomicT...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5650#issuecomment-95467175
[Test build #30816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30816/consoleFull) for PR 5650 at commit [`97d2e1d`](https://github.com/apache/spark/commit/97d2e1d86f6cb73269a5a11b7d8ce8b6808a3d89).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` class FreqItemset(namedtuple("FreqItemset", ["items", "freq"])):`
* `protected[sql] abstract class AtomicType extends DataType `
* `abstract class NumericType extends AtomicType `
* ` class Encoder[T <: AtomicType](columnType: NativeColumnType[T]) extends compression.Encoder[T] `
* ` class Decoder[T <: AtomicType](buffer: ByteBuffer, columnType: NativeColumnType[T])`
* ` class Encoder[T <: AtomicType](columnType: NativeColumnType[T]) extends compression.Encoder[T] `
* ` class Decoder[T <: AtomicType](buffer: ByteBuffer, columnType: NativeColumnType[T])`
* ` class Encoder[T <: AtomicType](columnType: NativeColumnType[T]) extends compression.Encoder[T] `
* ` class Decoder[T <: AtomicType](buffer: ByteBuffer, columnType: NativeColumnType[T])`
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7069][SQL] Rename NativeType -> AtomicT...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5650#issuecomment-95467199
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30816/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7069][SQL] Rename NativeType -> AtomicT...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5650#issuecomment-95465861
Going to re-open a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7069][SQL] Rename NativeType -> AtomicT...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5650#issuecomment-95464577
This also contains https://github.com/apache/spark/pull/5646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7069][SQL] Rename NativeType -> AtomicT...
Posted by rxin <gi...@git.apache.org>.
Github user rxin closed the pull request at:
https://github.com/apache/spark/pull/5650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7069][SQL] Rename NativeType -> AtomicT...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5650#issuecomment-95464700
[Test build #30816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30816/consoleFull) for PR 5650 at commit [`97d2e1d`](https://github.com/apache/spark/commit/97d2e1d86f6cb73269a5a11b7d8ce8b6808a3d89).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org