You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Chinmay Kulkarni (Jira)" <ji...@apache.org> on 2020/11/12 00:12:00 UTC
[jira] [Resolved] (PHOENIX-6212) Improve
SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs when
splitting is disabled
[ https://issues.apache.org/jira/browse/PHOENIX-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinmay Kulkarni resolved PHOENIX-6212.
---------------------------------------
Resolution: Fixed
Thanks for the review [~yanxinyi]. Committed to master and 4.x
> Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs when splitting is disabled
> -------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6212
> URL: https://issues.apache.org/jira/browse/PHOENIX-6212
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6212.master.patch
>
>
> We should fix [SystemCatalogIT.testSystemTableSplit()|https://github.com/apache/phoenix/blob/8aa243d1e35a2a9ac85c6c30f1e958289973c214/phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogIT.java#L65] so that it ensures that splitting SYSTEM.CATALOG fails if either
> phoenix.allow.system.catalog.rollback=true and/or
> phoenix.system.catalog.splittable=false
> Currently this test is not really ensuring that a split fails (see [this comment|https://github.com/apache/phoenix/pull/949#discussion_r516276781] for more details)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)