You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2015/10/20 16:51:50 UTC

[3/5] storm git commit: Adjusted memory parameters to be closer to what Yahoo uses in production. Fixed small bug

Adjusted memory parameters to be closer to what Yahoo uses in production.  Fixed small bug


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b60bb72c
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/b60bb72c
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/b60bb72c

Branch: refs/heads/master
Commit: b60bb72c9f572f5cdd99d8deeba1ab214d53e18d
Parents: 4c2cb4f
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Authored: Mon Oct 19 08:32:56 2015 -0500
Committer: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Committed: Mon Oct 19 08:32:56 2015 -0500

----------------------------------------------------------------------
 .../src/jvm/storm/starter/ThroughputVsLatency.java    | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/b60bb72c/examples/storm-starter/src/jvm/storm/starter/ThroughputVsLatency.java
----------------------------------------------------------------------
diff --git a/examples/storm-starter/src/jvm/storm/starter/ThroughputVsLatency.java b/examples/storm-starter/src/jvm/storm/starter/ThroughputVsLatency.java
index a9070ae..2608755 100644
--- a/examples/storm-starter/src/jvm/storm/starter/ThroughputVsLatency.java
+++ b/examples/storm-starter/src/jvm/storm/starter/ThroughputVsLatency.java
@@ -115,6 +115,10 @@ public class ThroughputVsLatency {
         StormSubmitter.submitTopology(name, stormConf, topology);
       }
     }
+
+    public boolean isLocal() {
+      return _local != null;
+    }
   }
 
   public static class FastRandomSentenceSpout extends BaseRichSpout {
@@ -388,12 +392,19 @@ public class ThroughputVsLatency {
     metricServer.serve();
     String url = metricServer.getUrl();
 
+    C cluster = new C(conf);
     conf.setNumWorkers(parallelism);
     conf.registerMetricsConsumer(backtype.storm.metric.HttpForwardingMetricsConsumer.class, url, 1);
     Map<String, String> workerMetrics = new HashMap<String, String>();
-    workerMetrics.put("CPU", "org.apache.storm.metrics.sigar.CPUMetric");
+    if (!cluster.isLocal()) {
+      //sigar uses JNI and does not work in local mode
+      workerMetrics.put("CPU", "org.apache.storm.metrics.sigar.CPUMetric");
+    }
     conf.put(Config.TOPOLOGY_WORKER_METRICS, workerMetrics);
     conf.put(Config.TOPOLOGY_BUILTIN_METRICS_BUCKET_SIZE_SECS, 10);
+    conf.put(Config.TOPOLOGY_WORKER_GC_CHILDOPTS,
+      "-XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+UseConcMarkSweepGC -XX:NewSize=128m -XX:CMSInitiatingOccupancyFraction=70 -XX:-CMSConcurrentMTEnabled");
+    conf.put(Config.TOPOLOGY_WORKER_CHILDOPTS, "-Xmx2g");
 
     TopologyBuilder builder = new TopologyBuilder();
 
@@ -403,7 +414,6 @@ public class ThroughputVsLatency {
     builder.setBolt("split", new SplitSentence(), numEach).shuffleGrouping("spout");
     builder.setBolt("count", new WordCount(), numEach).fieldsGrouping("split", new Fields("word"));
 
-    C cluster = new C(conf);
     try {
         cluster.submitTopology(name, conf, builder.createTopology());