You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by askprasanna <gi...@git.apache.org> on 2017/07/17 13:35:52 UTC
[GitHub] storm pull request #2217: [1.x-branch] [STORM-2505] OffsetManager should acc...
GitHub user askprasanna opened a pull request:
https://github.com/apache/storm/pull/2217
[1.x-branch] [STORM-2505] OffsetManager should account for offset voids when retur…
…ning the count of committed offsets
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/askprasanna/storm 1.x-2505
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2217
----
commit b661c3b2f0ef529ca33c3ba142f9440f39b8ef4f
Author: Prasanna Ranganathan <pr...@flipkart.com>
Date: 2017-06-07T12:33:09Z
[STORM-2505] OffsetManager should account for offset voids when returning the count of committed offsets
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2217
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2217: [1.x-branch] [STORM-2505] OffsetManager should account fo...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2217
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly c...
Posted by askprasanna <gi...@git.apache.org>.
Github user askprasanna closed the pull request at:
https://github.com/apache/storm/pull/2217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2217
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...
Posted by askprasanna <gi...@git.apache.org>.
Github user askprasanna commented on the issue:
https://github.com/apache/storm/pull/2217
Closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2217
@askprasanna Could I get you to update the commit message to reflect the current JIRA number? I checked if this would go on 1.0.x unmodified as well, but 1.0.x was before we added the OffsetManager class. Would you like to see if it can be ported to 1.0.x, or does it work for you if this only makes it into 1.2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2217
Merged via 6cfcbeef4cd2da9f601687966aa08f6b75e41597
@askprasanna
I can't use Github automatic close because this PR is not against master branch.
Could you close this PR? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2217
Let's just reword the commit title while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---