You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2022/12/07 20:46:01 UTC

[royale-compiler] 02/02: MXMLDataBindingParser: use constant instead of literal

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git

commit 1c3acfe9767359e35fd6fe0607d22be0946243db
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Wed Dec 7 12:39:55 2022 -0800

    MXMLDataBindingParser: use constant instead of literal
---
 .../royale/compiler/internal/tree/mxml/MXMLDataBindingParser.java      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLDataBindingParser.java b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLDataBindingParser.java
index ccd9fc72c..329ba167d 100644
--- a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLDataBindingParser.java
+++ b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLDataBindingParser.java
@@ -25,6 +25,7 @@ import java.util.Collection;
 import java.util.List;
 
 import org.apache.royale.compiler.common.ISourceLocation;
+import org.apache.royale.compiler.constants.IMXMLCoreConstants;
 import org.apache.royale.compiler.internal.mxml.MXMLDialect;
 import org.apache.royale.compiler.internal.parsing.ISourceFragment;
 import org.apache.royale.compiler.internal.parsing.SourceFragment;
@@ -154,7 +155,7 @@ class MXMLDataBindingParser
         {
             String physicalText = fragment.getPhysicalText();
             String text = fragment.getLogicalText();
-            if (physicalText.startsWith("<![CDATA[") && !text.startsWith("<![CDATA["))
+            if (physicalText.startsWith(IMXMLCoreConstants.cDataStart) && !text.startsWith(IMXMLCoreConstants.cDataStart))
             {
                 // CData cannot contain data binding
                 continue;