You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/05/01 20:52:58 UTC
[jira] Created: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Move lease handling codes out from FSNamesystem
-----------------------------------------------
Key: HADOOP-3334
URL: https://issues.apache.org/jira/browse/HADOOP-3334
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Attachment: 3334_20080501b.patch
3334_20080501b.patch: fixed the findbugs warning.
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Attachment: 3334_20080501.patch
3334_20080501.patch:
- created a new class LeaseManager
- synchronized LeaseManager object instead of sortedLease
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594872#action_12594872 ]
Hudson commented on HADOOP-3334:
--------------------------------
Integrated in Hadoop-trunk #483 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/483/])
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.0
>
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch, 3334_20080506.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-3334:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.18.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Nicholas!
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.0
>
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch, 3334_20080506.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Attachment: 3334_20080506.patch
3334_20080506.patch: updated with trunk. It passed all tests locally.
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch, 3334_20080506.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594295#action_12594295 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3334:
------------------------------------------------
According the test report, the only tested failed is TEST-org.apache.hadoop.fs.TestCopyFiles.xml.<init>. Is TestCopyFiles.xml a valid test? I cannot find a file named "TestCopyFiles.xml". Does anyone know why it failed?
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594027#action_12594027 ]
Hadoop QA commented on HADOOP-3334:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381356/3334_20080502.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 6 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/console
This message is automatically generated.
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Attachment: 3334_20080502.patch
3334_20080502.patch: fixed a bug
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593700#action_12593700 ]
Hadoop QA commented on HADOOP-3334:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381277/3334_20080501.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 6 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs -1. The patch appears to introduce 1 new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/console
This message is automatically generated.
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Status: Patch Available (was: Open)
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Status: Open (was: Patch Available)
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Status: Open (was: Patch Available)
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch, 3334_20080506.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594694#action_12594694 ]
Hadoop QA commented on HADOOP-3334:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381524/3334_20080506.patch
against trunk revision 653866.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2413/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2413/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2413/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2413/console
This message is automatically generated.
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch, 3334_20080506.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Status: Patch Available (was: Open)
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch, 3334_20080506.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3334:
-------------------------------------------
Status: Patch Available (was: Open)
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3334) Move lease handling codes out from
FSNamesystem
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594676#action_12594676 ]
Raghu Angadi commented on HADOOP-3334:
--------------------------------------
+1. Looks good.
> Move lease handling codes out from FSNamesystem
> -----------------------------------------------
>
> Key: HADOOP-3334
> URL: https://issues.apache.org/jira/browse/HADOOP-3334
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3334_20080501.patch, 3334_20080501b.patch, 3334_20080502.patch
>
>
> Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.