You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/02 06:15:26 UTC
[GitHub] [incubator-seatunnel] zhuangchong opened a new pull request, #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
zhuangchong opened a new pull request, #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
Improve the scheduler module to support more scheduling plugins
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhuangchong closed pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
zhuangchong closed pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
URL: https://github.com/apache/incubator-seatunnel/pull/2602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602#discussion_r965702972
##########
pom.xml:
##########
@@ -206,6 +206,11 @@
<artifactId>seatunnel-config-shade</artifactId>
<version>${seatunnel.config.shade.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-scheduler-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
Why declare submodules at root?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602#issuecomment-1241416606
Can you describe specifically what this PR does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] dijiekstra commented on pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
dijiekstra commented on PR #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602#issuecomment-1241437620
Great PR, I will review it at my leisure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] dijiekstra commented on a diff in pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
dijiekstra commented on code in PR #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602#discussion_r968365929
##########
seatunnel-server/seatunnel-app/pom.xml:
##########
@@ -148,7 +148,7 @@
<dependency>
<groupId>org.apache.seatunnel</groupId>
- <artifactId>seatunnel-spi</artifactId>
+ <artifactId>seatunnel-scheduler-api</artifactId>
Review Comment:
No need rename this module.We will have more interface definitions in future , not just scheduling related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhuangchong commented on pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602#issuecomment-1241433459
> Can you describe specifically what this PR does?
Improve the scheduler module to support more scheduling plugins
1. From the perspective of the code module structure, SeaTunnel is to support scheduler plug-in, and can support more scheduling plug-ins, such as dolphinscheduler, azkaban
2. The current code does not really implement scheduler plug-in
Configuration file:
The key of the current property is ds.* . If azkaban scheduling is added, what should this key be?
https://github.com/apache/incubator-seatunnel/pull/2602/files#diff-be5fe744bda2308d461ce12ee32f8cc115dac0682230814f2b96e6ee0f5ade27L29-R43
Plugin implementation:
At present, spring dependency injection is used. When adding a plug-in module, an interface has two implementation classes, and the project will report an error at this time.
I introduced the ConditionalOnProperty annotation. According to the value of the configuration file seatunnel.scheduler.type, which implementation class should be injected into spring, only one implementation class will take effect in the project.
https://github.com/apache/incubator-seatunnel/pull/2602/files#diff-b0fc519f508b3019a859edab06e94430b51bd2df0b7c8cd834076d97f07155efR32-R33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhuangchong commented on a diff in pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on code in PR #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602#discussion_r965971413
##########
pom.xml:
##########
@@ -206,6 +206,11 @@
<artifactId>seatunnel-config-shade</artifactId>
<version>${seatunnel.config.shade.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-scheduler-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
ok, It has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2602: [Improvement][seatunnel-server] Improve the scheduler module to support more scheduling plugins
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2602:
URL: https://github.com/apache/incubator-seatunnel/pull/2602#issuecomment-1261720970
> The module has been moved to a subproject, can this PR be closed?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org