You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2012/11/02 04:38:13 UTC

[jira] [Commented] (HDFS-4143) Change INodeFile.blocks to private

    [ https://issues.apache.org/jira/browse/HDFS-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489229#comment-13489229 ] 

Suresh Srinivas commented on HDFS-4143:
---------------------------------------

Inode.java - why make toString() final?

Other than this the patch looks good. +1 with Jenkins +1.
                
> Change INodeFile.blocks to private
> ----------------------------------
>
>                 Key: HDFS-4143
>                 URL: https://issues.apache.org/jira/browse/HDFS-4143
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4143_20121101.patch
>
>
> INodeFile.blocks is currently package private.  It is accessed directly in quite many case.  It is better to change it to package private and access via setter and getter methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira