[jira] [Resolved] (SPARK-3022) FindBinsForLevel in decision tree should call findBin only once for each feature

["Xiangrui Meng (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiangrui Meng resolved SPARK-3022.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.0

Issue resolved by pull request 1950
[https://github.com/apache/spark/pull/1950]

> FindBinsForLevel in decision tree should call findBin only once for each feature
> --------------------------------------------------------------------------------
>
>                 Key: SPARK-3022
>                 URL: https://issues.apache.org/jira/browse/SPARK-3022
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>    Affects Versions: 1.0.2
>            Reporter: Qiping Li
>             Fix For: 1.1.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> `findbinsForLevel` is applied to every `LabeledPoint` to find bins for all nodes at a given level. Given a specific `LabeledPoint` and a specific feature, the bin to put this labeled point should always be same.But in current implementation, `findBin` on a (labeledpoint, feature) pair is called for every node at a given level, which is a waste of computation. I proposed to call `findBin` only once and if a `LabeledPoint` is valid on a node, this result can be reused.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org