You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2023/02/14 00:04:53 UTC
[pinot] branch master updated: fix the default value for enabling multipart upload (#10275)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c0f61354aa fix the default value for enabling multipart upload (#10275)
c0f61354aa is described below
commit c0f61354aa9b6a03f5f136798bb50750115886e3
Author: Xiaobing <61...@users.noreply.github.com>
AuthorDate: Mon Feb 13 16:04:46 2023 -0800
fix the default value for enabling multipart upload (#10275)
---
.../src/main/java/org/apache/pinot/plugin/filesystem/S3Config.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3Config.java b/pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3Config.java
index 9d2fd6d3c2..28475f96ef 100644
--- a/pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3Config.java
+++ b/pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3Config.java
@@ -100,9 +100,10 @@ public class S3Config {
Integer.parseInt(pinotConfig.getProperty(SESSION_DURATION_SECONDS, DEFAULT_SESSION_DURATION_SECONDS));
_asyncSessionUpdateEnabled = Boolean.parseBoolean(
pinotConfig.getProperty(ASYNC_SESSION_UPDATED_ENABLED, DEFAULT_ASYNC_SESSION_UPDATED_ENABLED));
- // non-positive values to disable multipart upload.
+ // Objects uploaded via putObject are limited at 5G. Setting this to 5G by default, so that smaller objects
+ // continue to be uploaded by putObject methods just as before, while the larger ones are uploaded in multi parts.
_minObjectSizeForMultiPartUpload =
- DataSizeUtils.toBytes(pinotConfig.getProperty(MIN_OBJECT_SIZE_FOR_MULTI_PART_UPLOAD, "-1"));
+ DataSizeUtils.toBytes(pinotConfig.getProperty(MIN_OBJECT_SIZE_FOR_MULTI_PART_UPLOAD, "5G"));
_multiPartUploadPartSize = DataSizeUtils.toBytes(
pinotConfig.getProperty(MULTI_PART_UPLOAD_PART_SIZE, DEFAULT_MULTI_PART_UPLOAD_PART_SIZE));
Preconditions.checkArgument(_multiPartUploadPartSize > MULTI_PART_UPLOAD_MIN_PART_SIZE,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org